Bug 82294

Summary: [EFL][DRT] Implement LayoutTestController::layerTreeAsText.
Product: WebKit Reporter: Kangil Han <kangil.han>
Component: WebKit EFLAssignee: Kenneth Rohde Christiansen <kenneth>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, d-r, gyuyoung.kim, gyuyoung.kim, joone, kenneth, lucas.de.marchi, rakuco, tmpsantos, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Linux   
Bug Depends on: 79766    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Description Kangil Han 2012-03-26 22:06:17 PDT 
Implement LayoutTestController::layerTreeAsText.
Comment 1 Chris Dumez 2012-04-23 23:51:50 PDT 
This requires accelerated compositing which is currently disabled in EFL port. Shouldn't we add a dependency on 79766?
Comment 2 Kenneth Rohde Christiansen 2012-09-13 04:45:44 PDT 
WebKit2 already has


Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:WKStringRef WKBundleFrameCopyLayerTreeAsText(WKBundleFrameRef frameRef)
Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundleFramePrivate.h:WK_EXPORT WKStringRef WKBundleFrameCopyLayerTreeAsText(WKBundleFrameRef frame);

And I believe we enabled AC already.

Can we close this then.
Comment 3 Kangil Han 2012-09-13 04:56:45 PDT 
Okay.

One thing, AFAIK, AC is disabled now.
Comment 4 Kenneth Rohde Christiansen 2012-09-13 05:20:03 PDT 
(In reply to comment #3)
> Okay.
> 
> One thing, AFAIK, AC is disabled now.

Only on WebKit1 right?
Comment 5 Kangil Han 2012-09-13 05:42:22 PDT 
(In reply to comment #4)
> 
> Only on WebKit1 right?

WK2 also.
Comment 6 Kenneth Rohde Christiansen 2012-09-13 06:13:25 PDT 
Reopening to attach new patch.
Comment 7 Kenneth Rohde Christiansen 2012-09-13 06:13:28 PDT 
Created attachment 163853 [details]
Patch
Comment 8 Mikhail Pozdnyakov 2012-09-13 06:19:34 PDT 
Comment on attachment 163853 [details]
Patch

Looks nice
Comment 9 WebKit Review Bot 2012-09-13 07:14:52 PDT 
Comment on attachment 163853 [details]
Patch

Clearing flags on attachment: 163853

Committed r128454: <http://trac.webkit.org/changeset/128454>
Comment 10 WebKit Review Bot 2012-09-13 07:14:57 PDT 
All reviewed patches have been landed.  Closing bug.