Bug 82293
| Summary: | Refactor AnimationBase to increase code reuse | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Robin Cao <robin.webkit> |
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED WONTFIX | ||
| Severity: | Normal | CC: | ahmad.saleem792, dongseong.hwang, graouts |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | All | ||
| OS: | All | ||
Robin Cao
Currently, some utility functions in AnimationBase/KeyframeAnimation are copied to several places.
For example, the following functions are copied to:
WebCore/platform/graphics/texmap/TextureMapperAnimation.cpp
Source/WebCore/platform/graphics/qt/GraphicsLayerQt.cpp
static inline double solveEpsilon(double duration)
static inline double solveCubicBezierFunction(double p1x, double p1y, double p2x, double p2y, double t, double duration)
static inline double solveStepsFunction(int numSteps, bool stepAtStart, double t)
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ahmad Saleem
AnimationBase code is gone - https://github.com/WebKit/WebKit/commit/15433766d180265ef8953942e2ec0d23eb7d8f52
@Antoine - anything or we can close this?
As for these clean-ups:
GraphicsLayerQt.cpp - Qt port is gone.
TextureMapperAnimation.cpp - changed to NicosiaAnimation.cpp here: https://github.com/WebKit/WebKit/commit/dc4ce40f38f322ae0c829f50da2e36a766a511b0
solveEpsilon & solveStepsFunction -> in SVGAnimation (not in any other place).
solveCubicBezierFunction - Got deleted - https://github.com/WebKit/WebKit/commit/45b5180629e747e0e5f997ba3e24a779c07a292b
I think nothing much to do here.
Antoine Quint
This is no longer relevant.