Bug 82286 – [EFL][DRT] Implement LayoutTestController::execCommand

• Component: WebKit EFL
• Status: RESOLVED FIXED

[Kangil Han]

Implement LayoutTestController::execCommand for EFL DRT

[Sudarsana Nagineni (babu)]

Created attachment 138792 [details]
Patch

Implement LayoutTestController::execCommand

[Gyuyoung Kim]

Comment on attachment 138792 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=138792&action=review

> Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp:401
> +void DumpRenderTreeSupportEfl::executeCoreCommandByName(const Evas_Object* ewkView, const gchar* name, const gchar* value)

Why do you use gchar instead of char? EFL port should use glib library as less as possible.

> Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp:420
> +bool DumpRenderTreeSupportEfl::isCommandEnabled(const Evas_Object* ewkView, const gchar* name)

ditto.

[Sudarsana Nagineni (babu)]

(In reply to comment #2)
> (From update of attachment 138792 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=138792&action=review
> 
> > Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp:401
> > +void DumpRenderTreeSupportEfl::executeCoreCommandByName(const Evas_Object* ewkView, const gchar* name, const gchar* value)
> 
> Why do you use gchar instead of char? EFL port should use glib library as less as possible.

It's my mistake. I'm going to fix it. Thanks for reviewing.

[Sudarsana Nagineni (babu)]

Created attachment 138958 [details]
patch

Fixed comment #2

[Gyuyoung Kim]

Comment on attachment 138958 [details]
patch

Looks fine now.

[Raphael Kubo da Costa (:rakuco)]

Comment on attachment 138958 [details]
patch

Looks fine, even though it is rather unfortunate that we cannot exercise ewk_view_editor_command_execute() with these methods.

[Sudarsana Nagineni (babu)]

(In reply to comment #6)
> (From update of attachment 138958 [details])
> Looks fine, even though it is rather unfortunate that we cannot exercise ewk_view_editor_command_execute() with these methods.

Thanks for your review. Initially I looked around that public API and realised that we can't really use it for these LTC methods.

[Sudarsana Nagineni (babu)]

Created attachment 139189 [details]
Patch

rebased

[Sudarsana Nagineni (babu)]

Created attachment 140282 [details]
Patch

rebased again

[WebKit Review Bot]

Comment on attachment 140282 [details]
Patch

Rejecting attachment 140282 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
/efl/ChangeLog
Hunk #1 succeeded at 1 with fuzz 1.
patching file Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp
patching file Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.h
patching file Tools/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Antonio Go..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/12632750

[Sudarsana Nagineni (babu)]

Created attachment 140486 [details]
Patch

rebased

[WebKit Review Bot]

Comment on attachment 140486 [details]
Patch

Clearing flags on attachment: 140486

Committed r116285: <http://trac.webkit.org/changeset/116285>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.