Bug 82267

Summary: Build system prep work for upstreaming iOS changes
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: Tools / TestsAssignee: David Kilzer (:ddkilzer) <ddkilzer>
Severity: Normal CC: abarth, haraken, japhet, mitz, mrowe, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Description Flags
Patch mrowe: review+

Description David Kilzer (:ddkilzer) 2012-03-26 17:20:56 PDT
Created attachment 133934 [details]

Reviewed by NOBODY (OOPS!).

* DerivedSources.make: Move 'bison' into a variable and use
xcrun to find it on Mac OS X.
* bindings/scripts/preprocessor.pm:
(applyPreprocessor): Add local @args variable.
 3 files changed, 27 insertions(+), 4 deletions(-)
Comment 1 WebKit Review Bot 2012-03-26 17:24:22 PDT
Attachment 133934 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 3 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 2 Mark Rowe (bdash) 2012-03-26 17:28:57 PDT
Comment on attachment 133934 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=133934&action=review


> Source/WebCore/ChangeLog:10
> +        (applyPreprocessor): Add local @args variable.

An explanation of the benefit of this @args variable wouldn't hurt.

> Source/WebCore/bindings/scripts/preprocessor.pm:55
> +        $preprocessor = $gccLocation;
> +        push(@args, qw(-E -P -x c++));

It seems like the $gccLocation variable is now redundant.
Comment 3 David Kilzer (:ddkilzer) 2012-03-26 20:59:04 PDT
Committed r112203: <http://trac.webkit.org/changeset/112203>