Summary: | Layout Test media/video-beforeload-remove-source.html is timing out | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Emil A Eklund <eae> | ||||||
Component: | Tools / Tests | Assignee: | Ami Fischman <fischman> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | eric.carlson, fischman, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
URL: | http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=media%2Fvideo-beforeload-remove-source.html | ||||||||
Attachments: |
|
Description
Emil A Eklund
2012-03-26 16:32:04 PDT
Created attachment 135473 [details]
Patch
I don't know of a reference for the "beforeload" event so not sure how to justify this change on a principled level :/ Comment on attachment 135473 [details]
Patch
You are on a roll Ami! Keep going :-)
Comment on attachment 135473 [details] Patch Rejecting attachment 135473 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: atching file LayoutTests/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file LayoutTests/media/video-beforeload-remove-source.html patching file LayoutTests/platform/chromium/test_expectations.txt Hunk #1 FAILED at 4239. 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/chromium/test_expectations.txt.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Eric Carls..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/12323819 Created attachment 135608 [details]
Patch
Comment on attachment 135608 [details] Patch Rejecting attachment 135608 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 ERROR: /mnt/git/webkit-commit-queue/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/12325834 Comment on attachment 135608 [details] Patch Clearing flags on attachment: 135608 Committed r113211: <http://trac.webkit.org/changeset/113211> All reviewed patches have been landed. Closing bug. |