Summary: | Always set V8 wrappers via V8DOMWrapper::setJSWrapperFor* instead of WeakReferenceMap::set() | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Adam Klein <adamk> | ||||||||||
Component: | WebCore Misc. | Assignee: | Adam Klein <adamk> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | abarth, arv, eric.carlson, feature-media-reviews, haraken, japhet, webkit.review.bot | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Bug Depends on: | 82295, 82912, 83528 | ||||||||||||
Bug Blocks: | |||||||||||||
Attachments: |
|
Description
Adam Klein
2012-03-26 16:17:11 PDT
Created attachment 133922 [details]
Patch
Created attachment 133925 [details]
Fix isActiveNode assert
Comment on attachment 133925 [details] Fix isActiveNode assert Clearing flags on attachment: 133925 Committed r112199: <http://trac.webkit.org/changeset/112199> All reviewed patches have been landed. Closing bug. Got rolled out, just need to properly define SVGElemetInstance to fix cr-win build. Created attachment 134089 [details]
Patch for relanding
Committed r112318: <http://trac.webkit.org/changeset/112318> This was rolled out. Created attachment 136768 [details]
Patch
Comment on attachment 136768 [details]
Patch
Looks OK.
Comment on attachment 136768 [details] Patch Clearing flags on attachment: 136768 Committed r114034: <http://trac.webkit.org/changeset/114034> All reviewed patches have been landed. Closing bug. |