Allow expectations on directories in virtual test suites

• Component: New Bugs
• Status: RESOLVED FIXED

[Adrienne Walker]

Allow expectations on directories in virtual test suites

[Adrienne Walker]

Created attachment 133915 [details]
Patch

[Dirk Pranke]

Comment on attachment 133915 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=133915&action=review

> Tools/Scripts/webkitpy/layout_tests/port/base.py:1099
> +                return test_name.replace(suite.name, suite.base)

Your change will allow lookup_virtual_test_base() to handle paths that don't actually map onto base paths that exist. I had to convince myself that that was okay, but I think I did. 

Given that, I don't think you even need to do the get() on line 1096. You can just replace line 1096 with your 1099.

[Adrienne Walker]

(In reply to comment #2)
> (From update of attachment 133915 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=133915&action=review
> 
> > Tools/Scripts/webkitpy/layout_tests/port/base.py:1099
> > +                return test_name.replace(suite.name, suite.base)
> 
> Your change will allow lookup_virtual_test_base() to handle paths that don't actually map onto base paths that exist. I had to convince myself that that was okay, but I think I did. 

Yeah.  It looks like the calling code checks that the base path exists after doing the mapping, so I convinced myself that it seemed reasonable too.

> Given that, I don't think you even need to do the get() on line 1096. You can just replace line 1096 with your 1099.

Will do that on landing, thanks.

[Adrienne Walker]

Committed r112176: <http://trac.webkit.org/changeset/112176>