Bug 82188 – [Qt] Taps are sometimes not highlighted

• Component: WebKit2
• Status: RESOLVED FIXED

[Allan Sandfeld Jensen]

In some circumstances, such as scripted links, the activated element is not tap-highlighted.

It happens because WebPage::highlightPotentialActivation only looks for links, and incorrectly ends up highlighting nothing if it doesn't find a link.

[Allan Sandfeld Jensen]

Created attachment 133771 [details]
Patch

[Kenneth Rohde Christiansen]

Comment on attachment 133771 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=133771&action=review

> Source/WebKit2/ChangeLog:9
> +        the element returned by bestClickableNodeForTouchPoint.

how does this code ensure that you get the element returned by bestClickab... ?

Maybe we should have a separate method to always get what will be activated by bestClickablenode...

[Allan Sandfeld Jensen]

(In reply to comment #2)
> (From update of attachment 133771 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=133771&action=review
> 
> > Source/WebKit2/ChangeLog:9
> > +        the element returned by bestClickableNodeForTouchPoint.
> 
> how does this code ensure that you get the element returned by bestClickab... ?
>
By not overriding activatedNode if nothing is found. So it just stays unchanged.
 
> Maybe we should have a separate method to always get what will be activated by bestClickablenode...
Yeah, I was thinking about that. We could also add another parameter to return the responding node instead of the target node.

[Allan Sandfeld Jensen]

(In reply to comment #3)
> (In reply to comment #2)
> > (From update of attachment 133771 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=133771&action=review
> > 
> > Maybe we should have a separate method to always get what will be activated by bestClickablenode...
> Yeah, I was thinking about that. We could also add another parameter to return the responding node instead of the target node.

I have tested that now, and I do not think that behaviour is desirable. In many cases scripted elements share a common event-handler, if we highlight the element with the eventhandler, we would highlight almost the entire screen.

The uploaded patch works better.

[WebKit Review Bot]

Comment on attachment 133771 [details]
Patch

Clearing flags on attachment: 133771

Committed r112084: <http://trac.webkit.org/changeset/112084>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.