Bug 82160 – Add exception for the setter of value in AudioParam

• Component: Web Audio
• Status: RESOLVED INVALID

[Gao Chun]

If a value is set outside the allowable range described by minValue and maxValue an exception is thrown.

[Gao Chun]

Created attachment 136004 [details]
Patch

[Build Bot]

Comment on attachment 136004 [details]
Patch

Attachment 136004 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/12337826

[Chris Rogers]

Comment on attachment 136004 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=136004&action=review

Hi Chun, sorry for the trouble but after some careful thought I don't think we should throw exceptions for values outside the range minValue and maxValue.  This is because it will soon become possible to send "audio-rate" signals directly to params and even have negative frequencies (for FM synthesis, etc.)

I realize that the spec says it should throw an exception, but I believe this is wrong and the spec should change.

Throwing and exception for NaN and Inf still seems Ok

> Source/WebCore/Modules/webaudio/AudioGain.h:51
> +

I don't think we need to special-case AudioGain - please see below.

[Gao Chun]

Thanks.I Make it invalid.

[Eric Seidel (no email)]

Comment on attachment 136004 [details]
Patch

Cleared review? from attachment 136004 [details] so that this bug does not appear in http://webkit.org/pending-review.  If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).