Summary: | DFG int-to-double conversion should be revealed to CSE | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Filip Pizlo <fpizlo> | ||||||||||||||
Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> | ||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||
Severity: | Normal | CC: | gustavo, pnormand, xan.lopez | ||||||||||||||
Priority: | P2 | ||||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||||
Hardware: | All | ||||||||||||||||
OS: | All | ||||||||||||||||
Attachments: |
|
Description
Filip Pizlo
2012-03-24 15:28:03 PDT
Created attachment 133653 [details]
work in progress
Created attachment 133657 [details]
work in progress
I'm almost ready to start testing it...
Created attachment 133668 [details]
the patch
Created attachment 133673 [details]
the patch
Rebased patch.
Comment on attachment 133673 [details] the patch Attachment 133673 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/12129342 Comment on attachment 133673 [details] the patch Attachment 133673 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/12134270 (In reply to comment #6) > (From update of attachment 133673 [details]) > Attachment 133673 [details] did not pass qt-ews (qt): > Output: http://queues.webkit.org/results/12134270 Ooops, I need to write the 32-bit version of compileInt32ToDouble. :-( Created attachment 133695 [details]
the patch
Fix 32-bit.
Comment on attachment 133695 [details] the patch Attachment 133695 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/12134479 Comment on attachment 133695 [details] the patch Attachment 133695 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/12129524 (In reply to comment #9) > (From update of attachment 133695 [details]) > Attachment 133695 [details] did not pass efl-ews (efl): > Output: http://queues.webkit.org/results/12134479 Fix on the way ... it appears that in the process of moving #if's around, I broke 64-bit. Comment on attachment 133695 [details] the patch Attachment 133695 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/12131501 Created attachment 133696 [details]
the patch
Putting up for EWS.
Landed in http://trac.webkit.org/changeset/112040 |