Bug 82122
| Summary: | [Chromium] LayoutTests: css3/selector3/xml tests are flaky / have wrong expectations on Snow Leopard | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Pavel Feldman <pfeldman> |
| Component: | New Bugs | Assignee: | Ojan Vafai <ojan> |
| Status: | RESOLVED WONTFIX | ||
| Severity: | Normal | CC: | jchaffraix, kbr |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Pavel Feldman
At first it seemed like the expectations dependency graph glitch, but I saw more and more = TEXT results as I was marking tests as SNOWLEOPARD = TEXT in the expectations. Could they actually be flaky?
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ojan Vafai
Looks like ~120 of the css3/selectors3/xml tests are flaky. The text dump in some cases has two extra height==0, anonymous blocks that have empty RenderText's in them.
Kenneth Russell
These tests are failing in the same way on the Chromium 10.7 debug bot, e.g.:
http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Mac10.7%20%28dbg%29/builds/71
Though interestingly not on the 10.7 release bot, e.g.:
http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Mac10.7/builds/10973
Why would these differences in the render tree be occurring mainly in debug mode?
I'm going to generalize these expected results from "SNOWLEOPARD" to "MAC". Simply adding "LION" seems like the wrong approach since we might add a Mountain Lion bot soon.
Kenneth Russell
Committed r126487: <http://trac.webkit.org/changeset/126487>
Ojan Vafai
Could we restrict these lines to DEBUG only? They don't seem to fail on release.
Kenneth Russell
Yes, we could definitely tighten up the test expectations. All of the tests fail only on the debug bots except the following two:
css3/selectors3/xml/css3-modsel-101.xml fails on 10.6 Release but passes (with occasional flake) on 10.6 (dbg)
css3/selectors3/xml/css3-modsel-124b.xml fails on 10.6 Release but apparently passes on 10.6 (dbg)
Let me try to update the expectations now.
Kenneth Russell
Committed r126529: <http://trac.webkit.org/changeset/126529>
Ojan Vafai
Thanks! This way we at least have test coverage for these tests in release.
Stephen Chenney
Marked LayoutTest bugs, bugs with Chromium IDs, and some others as WontFix. Test failure bugs still are trackable via TestExpectations or disabled unit tests.