Summary: | [BlackBerry] Accelerated compositing layers fail to render when using WebPageCompositor | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Arvid Nilsson <anilsson> | ||||
Component: | WebKit BlackBerry | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | rwlbuis, tonikitoo, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | 81121 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
Arvid Nilsson
2012-03-23 16:58:12 PDT
Unfortunately there will be new tests, the output of OpenGL rendering is not currently testable in the BlackBerry port. I think this is obvious to the intended audience, so it should not need to be stated in the Changelog. Created attachment 133591 [details]
Patch
(In reply to comment #1) > Unfortunately there will be new tests, the output of OpenGL rendering is not currently testable in the BlackBerry port. I think this is obvious to the intended audience, so it should not need to be stated in the Changelog. there will be _no_ new tests =) Comment on attachment 133591 [details]
Patch
LGTM.
Comment on attachment 133591 [details] Patch Rejecting attachment 133591 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: /ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/platform/graphics/blackberry/LayerRenderer.cpp patching file Source/WebKit/blackberry/Api/WebPageCompositor.cpp Hunk #1 FAILED at 68. Hunk #2 FAILED at 79. 2 out of 2 hunks FAILED -- saving rejects to file Source/WebKit/blackberry/Api/WebPageCompositor.cpp.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Rob Buis']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/12123852 The commit-queue failure is probably just because 81121 is not in yet, and 81121 is a dependency. We can try again tomorrow, and see if 81121 is landed by then. Comment on attachment 133591 [details]
Patch
Alright, dependency was landed, we can try again.
Comment on attachment 133591 [details]
Patch
Retrying.
Comment on attachment 133591 [details] Patch Clearing flags on attachment: 133591 Committed r112026: <http://trac.webkit.org/changeset/112026> All reviewed patches have been landed. Closing bug. |