Summary: | [chromium] Instrument gesture animations with async traces | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Nat Duca <nduca> | ||||||||||
Component: | New Bugs | Assignee: | Nat Duca <nduca> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | cc-bugs, enne, gustavo, jamesr, pnormand, rjkroege, webkit.review.bot, wjmaclean, xan.lopez | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
Nat Duca
2012-03-23 12:01:13 PDT
This causes little messages about when a fling was runnign to show up in the timeline, care of new async stuff in about:Tracnig that jbates did for us. Created attachment 133530 [details]
Patch
Comment on attachment 133530 [details]
Patch
Would it be possible to put these trace events in the constructor and destructor of CCActiveGestureAnimation and ActivePlatformGestureAnimation so it happens automatically?
Omg thats a cool idea Created attachment 133654 [details]
Patch
Attachment 133654 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5]
Total errors found: 1 in 9 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 133654 [details] Patch Attachment 133654 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/12130232 Created attachment 133655 [details]
Patch
Created attachment 133656 [details]
Make gtk happy
Comment on attachment 133656 [details]
Make gtk happy
I like that much better.
Comment on attachment 133656 [details] Make gtk happy Clearing flags on attachment: 133656 Committed r112024: <http://trac.webkit.org/changeset/112024> All reviewed patches have been landed. Closing bug. (In reply to comment #12) > All reviewed patches have been landed. Closing bug. Nice. :-) |