Bug 82068
| Summary: | DumpRenderTree should clear window.sessionStorage between tests | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Dave Michael <dmichael> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | abarth, ap, dpranke, eric, mitz, ossy, rniwa, simon.fraser, tony |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Dave Michael
For the following bug (https://bugs.webkit.org/show_bug.cgi?id=32292), a new test (plugins/netscape-dom-access-and-reload.html) used the same sessionStorage variable name as another test (plugins/reloadplugins-and-pages.html). The second test failed because the variable was already set, causing the test to behave differently than expected.
32292 worked around it by using a distinct variable name, but it should probably be fixed in DumpRenderTree.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Dave Michael
(In reply to comment #0)
> For the following bug (https://bugs.webkit.org/show_bug.cgi?id=32292)
Sorry, I meant:
https://bugs.webkit.org/show_bug.cgi?id=80428
>, a new test (plugins/netscape-dom-access-and-reload.html) used the same sessionStorage variable name as another test (plugins/reloadplugins-and-pages.html). The second test failed because the variable was already set, causing the test to behave differently than expected.
>
> 32292 worked around it by using a distinct variable name, but it should probably be fixed in DumpRenderTree.
Make that 80428
Alexey Proskuryakov
Seems reasonable. With tests running in random order, one cannot depend on sessionStorage being set by a previous test.