Summary: | The JSC code generator can't handle boolean arguments for Callbacks | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tommy Widenflycht <tommyw> | ||||||
Component: | JavaScriptCore | Assignee: | Tommy Widenflycht <tommyw> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, haraken, japhet, ojan, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 81657 | ||||||||
Attachments: |
|
Description
Tommy Widenflycht
2012-03-23 04:23:18 PDT
Created attachment 133459 [details]
Patch
Comment on attachment 133459 [details]
Patch
OK!
Comment on attachment 133459 [details] Patch Oops, would you please add run-bindings-tests? https://trac.webkit.org/wiki/WebKitIDL#RunBindingsTests Created attachment 133463 [details]
Patch
Comment on attachment 133463 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=133463&action=review > Source/WebCore/bindings/scripts/test/TestCallback.idl:42 > + boolean callbackWithBoolean(in boolean boolParam); Sorry for my wrong comment in IRC. This does not test your change, since TestObj does not have the [Callback] IDL attribute. You need to add this test case to TestCallback.idl. Comment on attachment 133463 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=133463&action=review >> Source/WebCore/bindings/scripts/test/TestCallback.idl:42 >> + boolean callbackWithBoolean(in boolean boolParam); > > Sorry for my wrong comment in IRC. This does not test your change, since TestObj does not have the [Callback] IDL attribute. You need to add this test case to TestCallback.idl. This IS in TestCallback.idl... Comment on attachment 133463 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=133463&action=review >>> Source/WebCore/bindings/scripts/test/TestCallback.idl:42 >>> + boolean callbackWithBoolean(in boolean boolParam); >> >> Sorry for my wrong comment in IRC. This does not test your change, since TestObj does not have the [Callback] IDL attribute. You need to add this test case to TestCallback.idl. > > This IS in TestCallback.idl... Sorry for the repeated confusion:) Comment on attachment 133463 [details] Patch Clearing flags on attachment: 133463 Committed r111853: <http://trac.webkit.org/changeset/111853> All reviewed patches have been landed. Closing bug. |