Bug 82045

Summary: The JSC code generator can't handle boolean arguments for Callbacks
Product: WebKit Reporter: Tommy Widenflycht <tommyw>
Component: JavaScriptCoreAssignee: Tommy Widenflycht <tommyw>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, haraken, japhet, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 81657    
Attachments:
Description Flags
Patch
none
Patch none

Tommy Widenflycht
Reported 2012-03-23 04:23:18 PDT
CodeGeneratorJS.pm only handles DOMStrings and objects as arguments for a Callback, so I added support for boolean values as well.
Attachments
Patch (1.67 KB, patch)
2012-03-23 04:36 PDT, Tommy Widenflycht 		no flags
DetailsFormatted DiffDiff
Patch (11.79 KB, patch)
2012-03-23 05:10 PDT, Tommy Widenflycht 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tommy Widenflycht
Comment 1 2012-03-23 04:36:54 PDT
Created attachment 133459 [details] Patch
Kentaro Hara
Comment 2 2012-03-23 04:41:58 PDT
Comment on attachment 133459 [details] Patch OK!
Kentaro Hara
Comment 3 2012-03-23 04:42:40 PDT
Comment on attachment 133459 [details] Patch Oops, would you please add run-bindings-tests? https://trac.webkit.org/wiki/WebKitIDL#RunBindingsTests
Tommy Widenflycht
Comment 4 2012-03-23 05:10:28 PDT
Created attachment 133463 [details] Patch
Kentaro Hara
Comment 5 2012-03-23 05:18:20 PDT
Comment on attachment 133463 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=133463&action=review > Source/WebCore/bindings/scripts/test/TestCallback.idl:42 > + boolean callbackWithBoolean(in boolean boolParam); Sorry for my wrong comment in IRC. This does not test your change, since TestObj does not have the [Callback] IDL attribute. You need to add this test case to TestCallback.idl.
Tommy Widenflycht
Comment 6 2012-03-23 05:25:46 PDT
Comment on attachment 133463 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=133463&action=review >> Source/WebCore/bindings/scripts/test/TestCallback.idl:42 >> + boolean callbackWithBoolean(in boolean boolParam); > > Sorry for my wrong comment in IRC. This does not test your change, since TestObj does not have the [Callback] IDL attribute. You need to add this test case to TestCallback.idl. This IS in TestCallback.idl...
Kentaro Hara
Comment 7 2012-03-23 05:27:23 PDT
Comment on attachment 133463 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=133463&action=review >>> Source/WebCore/bindings/scripts/test/TestCallback.idl:42 >>> + boolean callbackWithBoolean(in boolean boolParam); >> >> Sorry for my wrong comment in IRC. This does not test your change, since TestObj does not have the [Callback] IDL attribute. You need to add this test case to TestCallback.idl. > > This IS in TestCallback.idl... Sorry for the repeated confusion:)
WebKit Review Bot
Comment 8 2012-03-23 06:01:51 PDT
Comment on attachment 133463 [details] Patch Clearing flags on attachment: 133463 Committed r111853: <http://trac.webkit.org/changeset/111853>
WebKit Review Bot
Comment 9 2012-03-23 06:01:56 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.