Summary: | WebKitWebView signals with GError parameters cause crashes when using GObject Introspection | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Gary Kramlich <grim> | ||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Major | CC: | gustavo, mrobinson, pnormand, rakuco | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Gary Kramlich
2012-03-22 15:24:59 PDT
Created attachment 133364 [details]
Patch
We still support versions of GTK+ older than 2.26, so I do not think we can merge this change as-is. Perhaps we could make the defintion of these signals a compile-time decision. Comment on attachment 133364 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=133364&action=review > Source/WebKit/gtk/ChangeLog:5 > + Added marshallers for BOOLEAN:OBJECT,STRING,BOXED and VOID:OBJECT,OBJECT,BOXED and changed the signal signatures for WebKitWebView::load-fail and WebKitWebView::resource-load-failed to use the new marshallers since GError has been a GBoxed type since Gtk 2.26. This fixes these signals for the gobject-introspection bindings. > + https://bugs.webkit.org/show_bug.cgi?id=81977 > + I really appreciate you including a ChangeLog for this change. In the future, it's better to generate the ChangeLog with Tools/Scripts/prepare-ChangeLogs and to put the long-form description below the "Revied by..." line. Comment on attachment 133364 [details]
Patch
Of course, the GLib version is the one that matters here, so this patch is fine. :)
Yeah sorry about the confusion, clearly I *meant* glib :) Also I used "webkit-patch upload" as mentioned at http://www.webkit.org/coding/contributing.html. I'll use the other one in the future! Thanks. Committed r112111: <http://trac.webkit.org/changeset/112111> |