Summary: | Web Inspector: breakpoints should be disabled while live editing JavaScript. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Pavel Feldman <pfeldman> | ||||||
Component: | Web Inspector (Deprecated) | Assignee: | Pavel Feldman <pfeldman> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | apavlov, bweinstein, dglazkov, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Pavel Feldman
2012-03-22 12:13:28 PDT
Created attachment 133464 [details]
Patch
Comment on attachment 133464 [details] Patch Attachment 133464 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12123558 New failing tests: inspector/editor/highlighter-basics.html Comment on attachment 133464 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=133464&action=review > Source/WebCore/ChangeLog:11 > + undo/redo wrapper and better detection of the noop opterations. opterations? > Source/WebCore/inspector/front-end/JavaScriptSourceFrame.js:355 > + if (this._isDirty) Shouldn't we also mute context menu? Created attachment 133627 [details]
[Patch] with fixed tests
Comment on attachment 133627 [details] [Patch] with fixed tests View in context: https://bugs.webkit.org/attachment.cgi?id=133627&action=review > Source/WebCore/inspector/front-end/TextViewer.js:1823 > + else trailing space Committed r112064: <http://trac.webkit.org/changeset/112064> |