Bug 81947

Summary: Web Inspector: breakpoints should be disabled while live editing JavaScript.
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: Web Inspector (Deprecated)Assignee: Pavel Feldman <pfeldman>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, dglazkov, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
[Patch] with fixed tests yurys: review+

Pavel Feldman
Reported 2012-03-22 12:13:28 PDT
We should not stop on breakpoints while script is being edited and is not committed.
Attachments
Patch (13.97 KB, patch)
2012-03-23 05:22 PDT, Pavel Feldman 		no flags
DetailsFormatted DiffDiff
[Patch] with fixed tests (17.48 KB, patch)
2012-03-24 02:51 PDT, Pavel Feldman 		yurys: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2012-03-23 05:22:23 PDT
Created attachment 133464 [details] Patch
WebKit Review Bot
Comment 2 2012-03-23 06:18:58 PDT
Comment on attachment 133464 [details] Patch Attachment 133464 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12123558 New failing tests: inspector/editor/highlighter-basics.html
Vsevolod Vlasov
Comment 3 2012-03-23 10:40:20 PDT
Comment on attachment 133464 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=133464&action=review > Source/WebCore/ChangeLog:11 > + undo/redo wrapper and better detection of the noop opterations. opterations? > Source/WebCore/inspector/front-end/JavaScriptSourceFrame.js:355 > + if (this._isDirty) Shouldn't we also mute context menu?
Pavel Feldman
Comment 4 2012-03-24 02:51:20 PDT
Created attachment 133627 [details] [Patch] with fixed tests
Yury Semikhatsky
Comment 5 2012-03-25 23:58:59 PDT
Comment on attachment 133627 [details] [Patch] with fixed tests View in context: https://bugs.webkit.org/attachment.cgi?id=133627&action=review > Source/WebCore/inspector/front-end/TextViewer.js:1823 > + else trailing space
Pavel Feldman
Comment 6 2012-03-26 01:56:47 PDT
Committed r112064: <http://trac.webkit.org/changeset/112064>
Note You need to log in before you can comment on or make changes to this bug.