Bug 81843

Summary:

refactor flexbox in preparation for flex-line-pack

Product:

WebKit

Reporter:

Tony Chang <tony>

Component:

New Bugs

Assignee:

Tony Chang <tony>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

mitz, ojan, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch for landing	none

Description Tony Chang 2012-03-21 16:36:58 PDT

refactor flexbox in preparation for flex-line-pack

Comment 1 Tony Chang 2012-03-21 16:40:48 PDT

Created attachment 133142 [details]
Patch

Comment 2 Tony Chang 2012-03-21 16:41:24 PDT

Let me know if this is too big.  I can split it into two patches.

Comment 3 Ojan Vafai 2012-03-21 16:47:55 PDT

Comment on attachment 133142 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=133142&action=review

> Source/WebCore/rendering/RenderFlexibleBox.cpp:1009
> +            if (flexAlignForChild(child) == AlignBaseline && minMarginAfterBaseline)

Nit: I'd move the minMarginAfterBaseline check to the outer for-loop and early-continue:
if (!minMarginAfterBaseline)
    continue;

Comment 4 Tony Chang 2012-03-21 17:02:34 PDT

Created attachment 133144 [details]
Patch for landing

Comment 5 WebKit Review Bot 2012-03-21 18:29:22 PDT

Comment on attachment 133144 [details]
Patch for landing

Clearing flags on attachment: 133144

Committed r111635: <http://trac.webkit.org/changeset/111635>

Comment 6 WebKit Review Bot 2012-03-21 18:29:26 PDT

All reviewed patches have been landed.  Closing bug.

Comment 7 mitz 2012-03-21 21:36:13 PDT

(In reply to comment #5)
> (From update of attachment 133144 [details])
> Clearing flags on attachment: 133144
> 
> Committed r111635: <http://trac.webkit.org/changeset/111635>

This caused bug 81870.

Comment 8 mitz 2012-03-21 21:59:18 PDT

Reverted r111635 in <http://trac.webkit.org/r111652>.

Comment 9 Tony Chang 2012-03-22 10:16:38 PDT

Committed r111720: <http://trac.webkit.org/changeset/111720>