Summary: | [Qt][WK2] Add QML API for handling database quotas | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alexander Færøy <ahf> | ||||||||
Component: | WebKit Qt | Assignee: | Alexander Færøy <ahf> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | menard, pierre.rossi, webkit.review.bot, zoltan | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Alexander Færøy
2012-03-21 12:33:27 PDT
Created attachment 133216 [details]
Patch
Attachment 133216 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1
Source/WebKit2/UIProcess/qt/QtWebPageUIClient.cpp:40: An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4]
Source/WebKit2/UIProcess/qt/QtWebPageUIClient.h:58: The parameter name "page" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/WebKit2/UIProcess/qt/QtWebPageUIClient.h:58: The parameter name "frame" adds no information, so it should be removed. [readability/parameter_name] [5]
Total errors found: 3 in 8 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 133225 [details]
Patch
Created attachment 133240 [details]
Patch
Committed r111684: <http://trac.webkit.org/changeset/111684> |