Summary: | Web Inspector: event listeners section is broken for about:blank page | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Yury Semikhatsky <yurys> | ||||||||
Component: | Web Inspector (Deprecated) | Assignee: | Yury Semikhatsky <yurys> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Attachments: |
|
Description
Yury Semikhatsky
2012-03-21 09:54:25 PDT
Created attachment 133075 [details]
Patch
Comment on attachment 133075 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=133075&action=review > Source/WebCore/inspector/front-end/ResourceUtils.js:63 > + if (WebInspector.inspectedPageURL === "about:blank") It sounds like we should instead parse about:blank as a valid URL. Created attachment 133078 [details]
Patch
(In reply to comment #2) > (From update of attachment 133075 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=133075&action=review > > > Source/WebCore/inspector/front-end/ResourceUtils.js:63 > > + if (WebInspector.inspectedPageURL === "about:blank") > > It sounds like we should instead parse about:blank as a valid URL. Done. Comment on attachment 133078 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=133078&action=review > Source/WebCore/inspector/front-end/utilities.js:460 > + var match = this.match(/^([^:]+):(?:\/\/)?([^\/:]*)(?::([\d]+))?(?:(\/[^#]*)(?:#(.*))?)?$/i); I would special case about:blank instead. Otherwise, non-urls can squeeze in. Created attachment 133133 [details]
Patch
(In reply to comment #5) > (From update of attachment 133078 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=133078&action=review > > > Source/WebCore/inspector/front-end/utilities.js:460 > > + var match = this.match(/^([^:]+):(?:\/\/)?([^\/:]*)(?::([\d]+))?(?:(\/[^#]*)(?:#(.*))?)?$/i); > > I would special case about:blank instead. Otherwise, non-urls can squeeze in. Done. Committed r111653: <http://trac.webkit.org/changeset/111653> |