Bug 81761 – Fix Gobject binding for sequence<T> for function return type.

• Component: New Bugs
• Status: RESOLVED FIXED

[Arko Saha]

After r111416 <http://trac.webkit.org/changeset/111416> revision I was trying to remove the custom binding for [Custom] Array getValues() and using sequence<MicroDataItemValue> getValues(). It works for JS bindings but for Gobject bindings it is trying to include #include "sequence<MicroDataItemValue>.h" in WebKitDOMPropertyNodeList.cpp. We should fix the same.

[Vineet Chaudhary (vineetc)]

Should we skip the function in the GObject Bindings?

[Vineet Chaudhary (vineetc)]

Created attachment 133017 [details]
quick_fix

Providing quick fix. This should solve your current build issue, but not sure if want these bindings in GObject.
I can see some changes in binding like below not related to this change, someone might have forgot to run bindings tests.

-#import <wtf/Float32Array.h>
-#import <wtf/Float64Array.h>
-#import <wtf/Int32Array.h>
+#import "Float32Array.h"
+#import "Float64Array.h"
+#import "Int32Array.h"

[WebKit Review Bot]

Attachment 133017 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/bindings/scripts/test/GObject/WebKitDOMFloat64Array.cpp:28:  Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Source/WebCore/bindings/scripts/test/GObject/WebKitDOMFloat64ArrayPrivate.h:26:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 2 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Kentaro Hara]

Comment on attachment 133017 [details]
quick_fix

View in context: https://bugs.webkit.org/attachment.cgi?id=133017&action=review

The change looks OK. If you want, please change r to r?.

> Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:214
> +    if ($codeGenerator->GetArrayType($functionReturnType)) {

Maybe we can just write $codeGenerator->GetArrayType($function->signature->type). $function->signature->type for setters would be empty.

[Kentaro Hara]

(In reply to comment #2)
> Created an attachment (id=133017) [details]
> quick_fix
> 
> Providing quick fix. This should solve your current build issue, but not sure if want these bindings in GObject.
> I can see some changes in binding like below not related to this change, someone might have forgot to run bindings tests.
> 
> -#import <wtf/Float32Array.h>
> -#import <wtf/Float64Array.h>
> -#import <wtf/Int32Array.h>
> +#import "Float32Array.h"
> +#import "Float64Array.h"
> +#import "Int32Array.h"

I rebaselined the run-bindings-tests results. Would you please rebase your patch with the latest WebKit trunk and re-upload it?

[Kentaro Hara]

(In reply to comment #4)
> > Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:214
> > +    if ($codeGenerator->GetArrayType($functionReturnType)) {
> 
> Maybe we can just write $codeGenerator->GetArrayType($function->signature->type). $function->signature->type for setters would be empty.

Sorry, your change is correct. Please ignore the above comment.

[Vineet Chaudhary (vineetc)]

Created attachment 133028 [details]
Patch

patch as per review comments.

[Kentaro Hara]

Comment on attachment 133028 [details]
Patch

OK. Thanks for the fix!

[WebKit Review Bot]

Comment on attachment 133028 [details]
Patch

Clearing flags on attachment: 133028

Committed r111535: <http://trac.webkit.org/changeset/111535>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.