Bug 81665 – [GTK] icon database requests not dispatched until new data arrives

• Component: WebKitGTK
• Status: RESOLVED FIXED

[Claudio Saavedra]

Apply this patch http://fpaste.org/I0hD/ to ephy master (rev. 5343bd) and you'll notice the following:

1. Opening ephy's history window (ctrl+ h) will show the list of hosts (in the left window) without any icons.
2. Without closing the history window, load any webpage (hopefully with favicon).
3. The icons will be loaded now.

Apparently the favicon requests done with webkit_favicon_database_get_favicon_pixbuf() are not dispatched until new data arrives in the database.

[Sergio Villar Senin]

Created attachment 133226 [details]
Patch

[Martin Robinson]

Comment on attachment 133226 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=133226&action=review

Okay. Please add this commit id to the 1.8 wiki page. One comment could be slightly cleaned up, I think.

> Source/WebKit/gtk/webkit/webkitfavicondatabase.cpp:543
> +    // By asking for the icon directly:
> +    // 1- if we don't get the icon data now, we'll get notified about it later (even if the initial import is not finished yet).
> +    // 2- if we get the icon data now, then success.

Perhaps you could make this slightly more concise:

We ask for the icon directly. If we don't get the icon data now, we'll be notified later (even if the database is still importing icons).

[Sergio Villar Senin]

Committed r111698: <http://trac.webkit.org/changeset/111698>