Bug 81648

Summary: op_mod fails on many interesting corner cases
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
work in progress
webkit-ews: commit-queue-
the patch oliver: review+

Filip Pizlo
Reported 2012-03-20 04:11:27 PDT
Negative numerator doesn't work right. Negative zero result doesn't work right. -2^31/-1 results in SIGFPE.
Attachments
work in progress (111.06 KB, patch)
2012-03-20 04:15 PDT, Filip Pizlo 		webkit-ews: commit-queue-
DetailsFormatted DiffDiff
the patch (120.97 KB, patch)
2012-03-20 17:03 PDT, Filip Pizlo 		oliver: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2012-03-20 04:15:48 PDT
Created attachment 132793 [details] work in progress Still need to make sure that x86-32 and ARMv7 work.
WebKit Review Bot
Comment 2 2012-03-20 04:18:22 PDT
Attachment 132793 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1 Source/JavaScriptCore/dfg/DFGOperations.h:82: DFG_OPERATION is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:2498: Missing space after , [whitespace/comma] [3] Total errors found: 2 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.
Early Warning System Bot
Comment 3 2012-03-20 06:44:08 PDT
Comment on attachment 132793 [details] work in progress Attachment 132793 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/11995254
Early Warning System Bot
Comment 4 2012-03-20 06:44:47 PDT
Comment on attachment 132793 [details] work in progress Attachment 132793 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/12001250
Filip Pizlo
Comment 5 2012-03-20 17:03:20 PDT
Created attachment 132932 [details] the patch
WebKit Review Bot
Comment 6 2012-03-20 17:10:05 PDT
Attachment 132932 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1 Source/JavaScriptCore/dfg/DFGOperations.h:82: DFG_OPERATION is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:2498: Missing space after , [whitespace/comma] [3] Total errors found: 2 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.
Oliver Hunt
Comment 7 2012-03-20 17:44:28 PDT
Comment on attachment 132932 [details] the patch fix theminor style issue before landerating
Filip Pizlo
Comment 8 2012-03-20 18:30:27 PDT
Landed in http://trac.webkit.org/changeset/111481
Note You need to log in before you can comment on or make changes to this bug.