Summary: | op_mod fails on many interesting corner cases | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Filip Pizlo <fpizlo> | ||||||
Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Filip Pizlo
2012-03-20 04:11:27 PDT
Created attachment 132793 [details]
work in progress
Still need to make sure that x86-32 and ARMv7 work.
Attachment 132793 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1
Source/JavaScriptCore/dfg/DFGOperations.h:82: DFG_OPERATION is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:2498: Missing space after , [whitespace/comma] [3]
Total errors found: 2 in 11 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 132793 [details] work in progress Attachment 132793 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/11995254 Comment on attachment 132793 [details] work in progress Attachment 132793 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/12001250 Created attachment 132932 [details]
the patch
Attachment 132932 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1
Source/JavaScriptCore/dfg/DFGOperations.h:82: DFG_OPERATION is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:2498: Missing space after , [whitespace/comma] [3]
Total errors found: 2 in 12 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 132932 [details]
the patch
fix theminor style issue before landerating
Landed in http://trac.webkit.org/changeset/111481 |