Bug 81635

Summary: Let CSSImageValue inherit directly from CSSValue.
Product: WebKit Reporter: Andreas Kling <kling>
Component: CSSAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, koivisto, macpherson, menard, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
webkit.review.bot: commit-queue-
Patch vee too koivisto: review+

Description Andreas Kling 2012-03-20 00:58:59 PDT
CSSImageValue currently inherits from CSSPrimitiveValue. To aid in style value refactoring we should simplify this to inheriting directly from CSSValue.
Comment 1 Andreas Kling 2012-03-20 01:11:25 PDT
Created attachment 132776 [details]
Patch
Comment 2 WebKit Review Bot 2012-03-20 02:15:31 PDT
Comment on attachment 132776 [details]
Patch

Attachment 132776 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12007164

New failing tests:
fast/dom/setPrimitiveValue.html
Comment 3 Antti Koivisto 2012-03-20 03:03:13 PDT
Comment on attachment 132776 [details]
Patch

Looks good but the bot is whiny.
Comment 4 Andreas Kling 2012-03-20 04:52:49 PDT
Created attachment 132802 [details]
Patch vee too

Additional testage.
Comment 5 Antti Koivisto 2012-03-20 05:07:45 PDT
Comment on attachment 132802 [details]
Patch vee too

r=me
Comment 6 Andreas Kling 2012-03-20 05:38:58 PDT
Committed r111387: <http://trac.webkit.org/changeset/111387>