| Summary: | [EFL] Fix build break because of PlatformString.h | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Gyuyoung Kim <gyuyoung.kim> | ||||
| Component: | WebKit EFL | Assignee: | Gyuyoung Kim <gyuyoung.kim> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | eric, gyuyoung.kim, lucas.de.marchi, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Gyuyoung Kim
2012-03-19 19:10:26 PDT
Created attachment 132745 [details]
Patch
Comment on attachment 132745 [details] Patch Clearing flags on attachment: 132745 Committed r111348: <http://trac.webkit.org/changeset/111348> All reviewed patches have been landed. Closing bug. I'm sorry I broke your build. This fix is wrong however. < > is used for system headers. Headers which are sought for beyond the current directory. <text/PlatformString> is suggesting that somehow "text" is some separate module, which is not true. This header should just be "PlatformString.h", I'm sorry for wrongly changing it to <wtf/PlatformString.h> earlier. <wtf/text/WTFString.h> is basically equivalent to PlatformString.h and some day we'll remove PlatformString.h I think. (In reply to comment #4) > I'm sorry I broke your build. This fix is wrong however. > > < > is used for system headers. Headers which are sought for beyond the current directory. > > <text/PlatformString> is suggesting that somehow "text" is some separate module, which is not true. > > This header should just be "PlatformString.h", I'm sorry for wrongly changing it to <wtf/PlatformString.h> earlier. <wtf/text/WTFString.h> is basically equivalent to PlatformString.h and some day we'll remove PlatformString.h I think. Ah, thank you for your fix again. |