Bug 81580

Summary: webkitpy: allow instance data in TestFailure objects
Product: WebKit Reporter: Dirk Pranke <dpranke>
Component: New BugsAssignee: Dirk Pranke <dpranke>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, ojan, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 71380    
Attachments:
Description Flags
Patch tony: review+

Dirk Pranke
Reported 2012-03-19 16:08:04 PDT
webkitpy: allow instance data in TestFailure objects
Attachments
Patch (6.73 KB, patch)
2012-03-19 16:08 PDT, Dirk Pranke 		tony: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dirk Pranke
Comment 1 2012-03-19 16:08:52 PDT
Created attachment 132699 [details] Patch
Eric Seidel (no email)
Comment 2 2012-03-19 16:22:36 PDT
Comment on attachment 132699 [details] Patch I feel like I attempted this change before and someone shot it down. Don't these things get serialized/de-serialized as part of being passed around? I'm fine with this change, but Ojan may have opinions?
Tony Chang
Comment 3 2012-03-19 16:34:06 PDT
Comment on attachment 132699 [details] Patch Looks like the reftest failure objects are already instances. Should be fine as long as we don't associate anything with the common failure types (which we create lots of instances of).
Dirk Pranke
Comment 4 2012-03-19 16:45:00 PDT
(In reply to comment #2) > (From update of attachment 132699 [details]) > I feel like I attempted this change before and someone shot it down. Don't these things get serialized/de-serialized as part of being passed around? I'm fine with this change, but Ojan may have opinions? I may have shot it down before :) They do get serialized, but since we're just adding strings and ints, this is safe and although I didn't like the idea of instance data before, I don't quite recall why I didn't, and it's clearly useful now.
Dirk Pranke
Comment 5 2012-03-19 18:21:26 PDT
Committed r111287: <http://trac.webkit.org/changeset/111287>
Note You need to log in before you can comment on or make changes to this bug.