Bug 81558

Summary: Web Inspector: CodeGeneratorInspector.py: switch Runtime, Network and DOM domains to typed API
Product: WebKit Reporter: Peter Rybin <prybin>
Component: Web Inspector (Deprecated)Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, dglazkov, joepeck, keishi, loislo, pfeldman, pmuellr, rik, vsevik, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Do not commit. Mac still has a problem
none
Do not commit. Mac still has a problem
none
Do not commit. Mac still has a problem
none
Do not commit. Mac still has a problem
none
Archive of layout-test-results from ec2-cr-linux-04
none
Do not commit. Tests still have a problem
none
Patch
none
Archive of layout-test-results from ec2-cr-linux-02
none
Patch
none
Archive of layout-test-results from ec2-cr-linux-02
none
Archive of layout-test-results from ec2-cr-linux-01
none
Patch none

Description Peter Rybin 2012-03-19 14:01:25 PDT 
Do not allow InspectorObject and other raw interfaces from Runtime, Network and DOM domains anymore.
Comment 1 Peter Rybin 2012-03-19 14:20:08 PDT 
Created attachment 132670 [details]
Patch
Comment 2 Peter Rybin 2012-03-19 14:23:53 PDT 
List of new FIXME to review (line numbers are in new file versions).

Source/WebCore/inspector/InjectedScript.cpp:177
Source/WebCore/inspector/InspectorDOMAgent.cpp:414
Source/WebCore/inspector/InspectorDOMAgent.cpp:1557
Comment 3 WebKit Review Bot 2012-03-19 14:25:47 PDT 
Attachment 132670 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/inspector/InjectedScript.cpp:66:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InjectedScript.cpp:76:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InjectedScript.cpp:112:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InjectedScript.cpp:263:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InjectedScript.h:66:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InjectedScript.h:73:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InjectedScript.h:85:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InjectedScript.h:108:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Total errors found: 8 in 17 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Build Bot 2012-03-19 16:14:05 PDT 
Comment on attachment 132670 [details]
Patch

Attachment 132670 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/11985701
Comment 5 Build Bot 2012-03-19 16:42:48 PDT 
Comment on attachment 132670 [details]
Patch

Attachment 132670 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/11990056
Comment 6 Build Bot 2012-03-19 16:47:40 PDT 
Comment on attachment 132670 [details]
Patch

Attachment 132670 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/11991060
Comment 7 WebKit Review Bot 2012-03-19 20:09:29 PDT 
Comment on attachment 132670 [details]
Patch

Attachment 132670 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12000027

New failing tests:
inspector/elements/dom-agent-query-selector.html
inspector/styles/undo-add-new-rule.html
inspector/audits/audits-panel-functional.html
inspector/styles/styles-add-new-rule.html
inspector/styles/add-new-rule-inline-style-csp.html
inspector/styles/commit-selector.html
inspector/styles/undo-set-selector-text.html
inspector/audits/audits-panel-noimages-functional.html
Comment 8 Pavel Feldman 2012-03-20 04:42:06 PDT 
Comment on attachment 132670 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=132670&action=review

So why do the tests fail?

> Source/WebCore/inspector/CodeGeneratorInspector.py:2261
> +

nit: 3 blank lines?

> Source/WebCore/inspector/InjectedScript.cpp:176
> +        RefPtr<TypeBuilder::Runtime::RemoteObject> result = TypeBuilder::Runtime::RemoteObject::create()

Wrap should never through. We should return ErrorString in this case instead.

> Source/WebCore/inspector/InspectorDOMAgent.cpp:414
> +        // FIXME: initialize root or error string param.

I am not sure I get the comment right. What you should do here is return ErrorString claiming that document is not available.

> Source/WebCore/inspector/InspectorDOMAgent.cpp:1557
> +        // FIXME: make a proper default value or return error message.

return error.
Comment 9 Peter Rybin 2012-03-21 13:36:14 PDT 
Comment on attachment 132670 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=132670&action=review

>> Source/WebCore/inspector/CodeGeneratorInspector.py:2261
>> +
> 
> nit: 3 blank lines?

Done

>> Source/WebCore/inspector/InjectedScript.cpp:176
>> +        RefPtr<TypeBuilder::Runtime::RemoteObject> result = TypeBuilder::Runtime::RemoteObject::create()
> 
> Wrap should never through. We should return ErrorString in this case instead.

Done

>> Source/WebCore/inspector/InspectorDOMAgent.cpp:414
>> +        // FIXME: initialize root or error string param.
> 
> I am not sure I get the comment right. What you should do here is return ErrorString claiming that document is not available.

Done
Comment 10 Peter Rybin 2012-03-21 13:37:10 PDT 
Created attachment 133104 [details]
Patch
Comment 11 Timothy Hatcher 2012-03-21 13:40:45 PDT 
Comment on attachment 133104 [details]
Patch

Please revise the ChangeLog and provide information on what changed and why (overall summary and per function).

More info with an example: http://www.webkit.org/coding/contributing.html#changelogs
Comment 12 Peter Rybin 2012-03-21 14:01:25 PDT 
Created attachment 133110 [details]
Patch
Comment 13 Timothy Hatcher 2012-03-21 14:03:38 PDT 
Comment on attachment 133110 [details]
Patch

My previous request still stands. Please revise the ChangeLog.
Comment 14 WebKit Review Bot 2012-03-21 14:03:40 PDT 
Attachment 133110 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/inspector/InjectedScript.cpp:66:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InjectedScript.cpp:76:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InjectedScript.cpp:112:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InjectedScript.cpp:259:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InjectedScript.h:66:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InjectedScript.h:73:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InjectedScript.h:85:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InjectedScript.h:108:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Total errors found: 8 in 18 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 15 Peter Rybin 2012-03-21 14:36:49 PDT 
(In reply to comment #11)
> (From update of attachment 133104 [details])
> Please revise the ChangeLog and provide information on what changed and why (overall summary and per function).
> 
> More info with an example: http://www.webkit.org/coding/contributing.html#changelogs

Hi Timothy
The change is pretty much mechanical. In all functions of 3 listed domains InspectorObject and InspectorArray are completely replaced with corresponding auto-generated types from TypeBuilder according to Inspector.json protocol definition.
Are you sure you want this description per function? This is a mechanical work, and all I can write in functions is probably a repeating statement or retell the raw diff.
Peter
Comment 16 Peter Rybin 2012-03-21 14:48:11 PDT 
Created attachment 133114 [details]
Do not commit. Mac still has a problem
Comment 17 WebKit Review Bot 2012-03-21 14:50:34 PDT 
Attachment 133114 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/inspector/InjectedScript.cpp:66:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InjectedScript.cpp:76:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InjectedScript.cpp:112:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InjectedScript.cpp:259:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InjectedScript.h:66:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InjectedScript.h:73:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InjectedScript.h:85:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InjectedScript.h:108:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Total errors found: 8 in 18 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 18 Build Bot 2012-03-21 15:13:50 PDT 
Comment on attachment 133114 [details]
Do not commit. Mac still has a problem

Attachment 133114 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/12070687
Comment 19 Build Bot 2012-03-21 15:16:07 PDT 
Comment on attachment 133114 [details]
Do not commit. Mac still has a problem

Attachment 133114 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/12102003
Comment 20 WebKit Review Bot 2012-03-21 16:08:25 PDT 
Comment on attachment 133114 [details]
Do not commit. Mac still has a problem

Attachment 133114 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12090637

New failing tests:
inspector/elements/dom-agent-query-selector.html
inspector/styles/undo-add-new-rule.html
inspector/audits/audits-panel-functional.html
inspector/styles/styles-add-new-rule.html
inspector/styles/add-new-rule-inline-style-csp.html
inspector/styles/commit-selector.html
inspector/styles/undo-set-selector-text.html
inspector/audits/audits-panel-noimages-functional.html
Comment 21 WebKit Review Bot 2012-03-21 17:00:09 PDT 
Comment on attachment 133114 [details]
Do not commit. Mac still has a problem

Attachment 133114 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12071686

New failing tests:
inspector/elements/dom-agent-query-selector.html
inspector/styles/undo-add-new-rule.html
inspector/audits/audits-panel-functional.html
inspector/styles/styles-add-new-rule.html
inspector/styles/add-new-rule-inline-style-csp.html
inspector/styles/commit-selector.html
inspector/styles/undo-set-selector-text.html
inspector/audits/audits-panel-noimages-functional.html
Comment 22 Timothy Hatcher 2012-03-21 17:31:34 PDT 
(In reply to comment #15)
> (In reply to comment #11)
> > (From update of attachment 133104 [details] [details])
> > Please revise the ChangeLog and provide information on what changed and why (overall summary and per function).
> > 
> > More info with an example: http://www.webkit.org/coding/contributing.html#changelogs
> 
> Hi Timothy
> The change is pretty much mechanical. In all functions of 3 listed domains InspectorObject and InspectorArray are completely replaced with corresponding auto-generated types from TypeBuilder according to Inspector.json protocol definition.
> Are you sure you want this description per function? This is a mechanical work, and all I can write in functions is probably a repeating statement or retell the raw diff.
> Peter

The new comment at the top of the ChangeLog is good. Thanks for adding that. Per function comments in this case are not needed.
Comment 23 Peter Rybin 2012-03-22 15:05:00 PDT 
Created attachment 133355 [details]
Do not commit. Mac still has a problem
Comment 24 WebKit Review Bot 2012-03-22 15:08:58 PDT 
Attachment 133355 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/inspector/InjectedScript.cpp:66:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InjectedScript.cpp:76:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InjectedScript.cpp:112:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InjectedScript.cpp:259:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InjectedScript.h:66:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InjectedScript.h:73:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InjectedScript.h:85:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InjectedScript.h:108:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Total errors found: 8 in 19 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 25 Build Bot 2012-03-22 15:28:57 PDT 
Comment on attachment 133355 [details]
Do not commit. Mac still has a problem

Attachment 133355 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/12121198
Comment 26 WebKit Review Bot 2012-03-22 16:23:05 PDT 
Comment on attachment 133355 [details]
Do not commit. Mac still has a problem

Attachment 133355 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12103020

New failing tests:
inspector/elements/dom-agent-query-selector.html
inspector/styles/undo-add-new-rule.html
inspector/audits/audits-panel-functional.html
inspector/styles/styles-add-new-rule.html
inspector/styles/add-new-rule-inline-style-csp.html
inspector/styles/commit-selector.html
inspector/styles/undo-set-selector-text.html
inspector/audits/audits-panel-noimages-functional.html
Comment 27 Build Bot 2012-03-22 17:40:57 PDT 
Comment on attachment 133355 [details]
Do not commit. Mac still has a problem

Attachment 133355 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/12122329
Comment 28 Peter Rybin 2012-03-23 11:00:17 PDT 
Created attachment 133511 [details]
Do not commit. Mac still has a problem
Comment 29 Peter Rybin 2012-03-23 12:26:18 PDT 
Created attachment 133533 [details]
Do not commit. Mac still has a problem
Comment 30 WebKit Review Bot 2012-03-23 12:29:54 PDT 
Attachment 133533 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/inspector/InjectedScript.cpp:66:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InjectedScript.cpp:76:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InjectedScript.cpp:112:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InjectedScript.cpp:259:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InjectedScript.h:66:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InjectedScript.h:73:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InjectedScript.h:85:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InjectedScript.h:108:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Total errors found: 8 in 19 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 31 WebKit Review Bot 2012-03-23 13:27:03 PDT 
Comment on attachment 133533 [details]
Do not commit. Mac still has a problem

Attachment 133533 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12117782

New failing tests:
inspector/elements/dom-agent-query-selector.html
inspector/styles/undo-add-new-rule.html
inspector/audits/audits-panel-functional.html
inspector/styles/styles-add-new-rule.html
inspector/styles/add-new-rule-inline-style-csp.html
inspector/styles/commit-selector.html
inspector/styles/undo-set-selector-text.html
inspector/audits/audits-panel-noimages-functional.html
Comment 32 WebKit Review Bot 2012-03-23 13:27:13 PDT 
Created attachment 133548 [details]
Archive of layout-test-results from ec2-cr-linux-04

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-04  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Comment 33 Peter Rybin 2012-03-23 15:40:56 PDT 
Created attachment 133574 [details]
Do not commit. Tests still have a problem
Comment 34 WebKit Review Bot 2012-03-23 15:45:06 PDT 
Attachment 133574 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/inspector/InjectedScript.cpp:66:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InjectedScript.cpp:76:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InjectedScript.cpp:112:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InjectedScript.cpp:259:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InjectedScript.h:66:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InjectedScript.h:73:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InjectedScript.h:85:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InjectedScript.h:108:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Total errors found: 8 in 19 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 35 WebKit Review Bot 2012-03-26 07:52:23 PDT 
Comment on attachment 133574 [details]
Do not commit. Tests still have a problem

Rejecting attachment 133574 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
ce/WebCore/inspector/InspectorRuntimeAgent.h
patching file Source/WebCore/inspector/InspectorValues.h
patching file Source/WebCore/inspector/ScriptCallFrame.cpp
patching file Source/WebCore/inspector/ScriptCallFrame.h
patching file Source/WebCore/inspector/ScriptCallStack.cpp
patching file Source/WebCore/inspector/ScriptCallStack.h

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Pavel Feld..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/12132816
Comment 36 Peter Rybin 2012-03-26 15:49:37 PDT 
Created attachment 133911 [details]
Patch
Comment 37 WebKit Review Bot 2012-03-26 16:00:25 PDT 
Attachment 133911 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/inspector/InjectedScript.cpp:66:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InjectedScript.cpp:76:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InjectedScript.cpp:112:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InjectedScript.cpp:259:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InjectedScript.h:66:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InjectedScript.h:73:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InjectedScript.h:85:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InjectedScript.h:108:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Total errors found: 8 in 18 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 38 WebKit Review Bot 2012-03-26 17:53:35 PDT 
Comment on attachment 133911 [details]
Patch

Attachment 133911 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12141228

New failing tests:
inspector/elements/dom-agent-query-selector.html
inspector/styles/undo-add-new-rule.html
inspector/audits/audits-panel-functional.html
inspector/styles/styles-add-new-rule.html
inspector/styles/add-new-rule-inline-style-csp.html
inspector/styles/commit-selector.html
http/tests/inspector/modify-cross-domain-rule.html
inspector/styles/undo-set-selector-text.html
inspector/audits/audits-panel-noimages-functional.html
Comment 39 WebKit Review Bot 2012-03-26 17:53:44 PDT 
Created attachment 133945 [details]
Archive of layout-test-results from ec2-cr-linux-02

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-02  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Comment 40 Peter Rybin 2012-03-27 18:55:14 PDT 
Created attachment 134196 [details]
Patch
Comment 41 WebKit Review Bot 2012-03-27 19:02:12 PDT 
Attachment 134196 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/inspector/InjectedScript.cpp:66:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InjectedScript.cpp:76:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InjectedScript.cpp:112:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InjectedScript.cpp:259:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InjectedScript.h:66:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InjectedScript.h:73:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InjectedScript.h:85:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InjectedScript.h:108:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Total errors found: 8 in 18 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 42 WebKit Review Bot 2012-03-27 20:30:13 PDT 
Comment on attachment 134196 [details]
Patch

Attachment 134196 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12145921

New failing tests:
inspector/audits/audits-panel-functional.html
inspector/audits/audits-panel-noimages-functional.html
Comment 43 WebKit Review Bot 2012-03-27 20:30:21 PDT 
Created attachment 134209 [details]
Archive of layout-test-results from ec2-cr-linux-02

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-02  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Comment 44 WebKit Review Bot 2012-03-27 21:38:37 PDT 
Comment on attachment 134196 [details]
Patch

Attachment 134196 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12142935

New failing tests:
inspector/audits/audits-panel-functional.html
inspector/audits/audits-panel-noimages-functional.html
Comment 45 WebKit Review Bot 2012-03-27 21:38:46 PDT 
Created attachment 134215 [details]
Archive of layout-test-results from ec2-cr-linux-01

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-01  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Comment 46 Peter Rybin 2012-03-28 10:17:19 PDT 
Created attachment 134326 [details]
Patch
Comment 47 WebKit Review Bot 2012-03-28 10:25:52 PDT 
Attachment 134326 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/inspector/InjectedScript.cpp:66:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InjectedScript.cpp:76:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InjectedScript.cpp:112:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InjectedScript.cpp:259:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InjectedScript.h:66:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InjectedScript.h:73:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InjectedScript.h:85:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InjectedScript.h:108:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Total errors found: 8 in 18 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 48 Vsevolod Vlasov 2012-03-28 12:45:15 PDT 
Committed r112428: <http://trac.webkit.org/changeset/112428>
Comment 49 Vsevolod Vlasov 2012-03-29 07:59:11 PDT 
Comment on attachment 134326 [details]
Patch

Clearing r?