Bug 81557

Summary: [chromium] Remove misleading double-if
Product: WebKit Reporter: Dana Jansens <danakj>
Component: New BugsAssignee: Dana Jansens <danakj>
Status: RESOLVED FIXED    
Severity: Normal CC: backer, cc-bugs, enne, jamesr, piman, reveman, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Dana Jansens
Reported 2012-03-19 13:54:16 PDT
[chromium] Remove misleading double-if
Attachments
Patch (1.89 KB, patch)
2012-03-19 13:54 PDT, Dana Jansens 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dana Jansens
Comment 1 2012-03-19 13:54:59 PDT
Created attachment 132660 [details] Patch
Dana Jansens
Comment 2 2012-03-19 13:56:13 PDT
The code does the following: m_paintRect = dirtyLayerRect; if (dirtyLayerRect.isEmpty()) return; // Now we know dirtyLayerRect is not empty. Thus m_paintRect is not empty. The check below is always true. if (!m_paintRect.isEmpty()) m_requestedUpdateTilesRect = IntRect(left, top, right - left + 1, bottom - top + 1);
Adrienne Walker
Comment 3 2012-03-19 14:09:19 PDT
Comment on attachment 132660 [details] Patch Yeah, that check looks totally unnecessary.
WebKit Review Bot
Comment 4 2012-03-19 15:27:40 PDT
Comment on attachment 132660 [details] Patch Clearing flags on attachment: 132660 Committed r111260: <http://trac.webkit.org/changeset/111260>
WebKit Review Bot
Comment 5 2012-03-19 15:27:44 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.