Bug 81501
| Summary: | Remove shadow dom tests from Skipped by adding internals method. | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Shinya Kawanaka <shinyak> |
| Component: | DOM | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED WONTFIX | ||
| Severity: | Normal | CC: | ahmad.saleem792, ap, bfulgham, dglazkov, dominicc, hayato, morrita, rniwa, rolandsteiner, shinyak |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 148695 | ||
Shinya Kawanaka
A lot of shadow dom tests have been skipped except chromium port, because SHADOW_DOM flag is not enabled in non-chromium ports.
However, we can use a adapter method defined in polyfill.js to use 'new WebKitShadowRoot'.
Maybe we can also define some internals method to add multiple shadow subtrees.
If we add some internals method to add multiple shadow subtrees, we can remove a lot of tests from Skipped list.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ahmad Saleem
rniwa@webkit.org - Is it something we needed or since Webkit is already going toward Shadow DOM v1 implementation slowly, we can mark this as "RESOLVED WONTFIX" and focus on actual implementation because it seems to be about "polypill" (stop gap) solution.
Ryosuke Niwa
Yeah, this is won't at this point. We have a sufficient test coverage of v1 API everywhere now.