[BlackBerry] Use GraphicsContext::fillPath() and strokePath instead of drawPath() in RenderThemeBlackBerry

• Component: WebKit BlackBerry
• Status: RESOLVED FIXED

[Leo Yang]

RenderThemeBlackBerry.cpp is now using GraphicsContext::drawPath().

[Leo Yang]

Created attachment 132537 [details]
Patch

[Rob Buis]

Comment on attachment 132537 [details]
Patch

We should work on getting rid of using drawPath, it can be replaced by using fillPath/strokePath. This means RenderThemeBlackBerry has to be adapted to use those instead.

[Leo Yang]

(In reply to comment #2)
> (From update of attachment 132537 [details])
> We should work on getting rid of using drawPath, it can be replaced by using fillPath/strokePath. This means RenderThemeBlackBerry has to be adapted to use those instead.

If we replace drawPath with fillPath and strokePath, there is some overhead:

826     if (paintingDisabled())
 827         return;
 828 
 829     SkPath path = *pathToFill.platformPath();
 830     if (!isPathSkiaSafe(getCTM(), path))
 831       return;
 832 
 833     const GraphicsContextState& state = m_state;
 834     path.setFillType(state.fillRule == RULE_EVENODD ?
 835         SkPath::kEvenOdd_FillType : SkPath::kWinding_FillType);

This block of code will be unnecessarily called twice.

[Leo Yang]

(In reply to comment #3)
> (In reply to comment #2)
> > (From update of attachment 132537 [details] [details])
> > We should work on getting rid of using drawPath, it can be replaced by using fillPath/strokePath. This means RenderThemeBlackBerry has to be adapted to use those instead.
> 
> If we replace drawPath with fillPath and strokePath, there is some overhead:
> 
> 826     if (paintingDisabled())
>  827         return;
>  828 
>  829     SkPath path = *pathToFill.platformPath();
>  830     if (!isPathSkiaSafe(getCTM(), path))
>  831       return;
>  832 
>  833     const GraphicsContextState& state = m_state;
>  834     path.setFillType(state.fillRule == RULE_EVENODD ?
>  835         SkPath::kEvenOdd_FillType : SkPath::kWinding_FillType);
> 
> This block of code will be unnecessarily called twice.

@rob: what do you think? I can move drawPath implementation to a separated new file or RenderThemeBlackBerry if you agree.

[Leo Yang]

Change bug title

[Leo Yang]

Created attachment 134985 [details]
Patch v2

Substituting drawPath() by fillPath() and strokePath()

[Rob Buis]

Comment on attachment 134985 [details]
Patch v2

Looks fine.

[Leo Yang]

Thanks for your review.

[WebKit Review Bot]

Comment on attachment 134985 [details]
Patch v2

Clearing flags on attachment: 134985

Committed r112814: <http://trac.webkit.org/changeset/112814>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.