Bug 81478 – CSS3 calc: background positioning works with mixed percent/absolute expressions

• Component: New Bugs
• Status: RESOLVED FIXED

[Mike Lawther]

CSS3 calc: background positioning works with mixed percent/absolute expressions

[Mike Lawther]

Created attachment 132515 [details]
Patch

[Mike Lawther]

Here is the test that is now passing: http://trac.webkit.org/browser/trunk/LayoutTests/css3/calc/background-position-parsing.html.

Just linking here since it doesn't show up in the review as the test itself hasn't changed.

[Luke Macpherson]

Life will be easier if could find a way to add this to primitiveValue->convertToLength and then just use it everywhere - that way there won't be special cases all over the place.

[Ojan Vafai]

Comment on attachment 132515 [details]
Patch

I agree with Luke, we should see if there are good helper functions for this. I guess it's a little tricky because sometimes you need to handle Auto lengths and sometimes you don't?

[WebKit Review Bot]

Comment on attachment 132515 [details]
Patch

Clearing flags on attachment: 132515

Committed r111200: <http://trac.webkit.org/changeset/111200>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Mike Lawther]

Hmm, if I could roll it in there, I think that means I could remove the external distinction between isPercent and isCalculatedPercentageWithLength. All of the isLength() and isPercentage() cases would also end up getting factored out as well.