|Summary:||CSS3 calc: make mask images work with mixed percent/absolute|
|Product:||WebKit||Reporter:||Mike Lawther <mikelawther>|
|Component:||New Bugs||Assignee:||Mike Lawther <mikelawther>|
|Severity:||Normal||CC:||macpherson, menard, webkit.review.bot|
|Version:||528+ (Nightly build)|
|Bug Depends on:|
Description Mike Lawther 2012-03-18 17:50:10 PDT
CSS3 calc: make mask images work with mixed percent/absolute
Comment 2 Mike Lawther 2012-03-18 17:54:34 PDT
For your reviewing pleasure, this is the testcase that is now passing: http://trac.webkit.org/browser/trunk/LayoutTests/css3/calc/simple-composited-mask.html Just linking it here since it doesn't show up in the review as the test itself is unchanged.
Comment 3 Ojan Vafai 2012-03-19 10:23:13 PDT
Comment on attachment 132514 [details] Patch Sigh. So much duplicate code. It's not your fault though. If you wanted to do a cleanup patch after this, you could move the duplicated code in mapFillSize into a static helper function (i.e. lines 4230-4239 are identical to 4241-4250). r=me if you decide to do that.
Comment 4 WebKit Review Bot 2012-03-19 11:02:53 PDT
Comment on attachment 132514 [details] Patch Clearing flags on attachment: 132514 Committed r111205: <http://trac.webkit.org/changeset/111205>
Comment 5 WebKit Review Bot 2012-03-19 11:02:58 PDT
All reviewed patches have been landed. Closing bug.