Bug 81472

Summary:

New renderer for SVGLineElement

Product:

WebKit

Reporter:

Renata Hodovan <rhodovan.u-szeged>

Component:

SVG

Assignee:

Renata Hodovan <rhodovan.u-szeged>

Status:

RESOLVED INVALID

Severity:

Normal

CC:

dglazkov, krit, rakuco, webkit.review.bot, zimmermann

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

65236

Attachments:

Description	Flags
Draft patch	none

Renata Hodovan

Reported 2012-03-18 05:20:31 PDT

New renderer for SVGLineElement

Attachments
Draft patch (22.31 KB, patch) 2012-03-19 00:08 PDT, Renata Hodovan	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Renata Hodovan

Comment 1 2012-03-19 00:08:19 PDT

Created attachment 132549 [details] Draft patch This is a draft patch with a few ambiguous points. In this approach I use GraphicsContext:drawLine() method for displaying the lines. It's implemented on all platforms but I have a problem with them: anitaliasing is setted by the member antiAliasingForRectsAndLines what is default false. So the lines will be coarse. What should I do with this? The second thing is RenderSVGLine::shapeDependentStrokeContains(). I have a solution for this but it's never called because lines are considered as styled elements and RenderSVGShape::strokeContains() will use the ancestor's function. Any idea? The last thing: what is the difference between filling and stroking lines? There has any point having a line w/o stroke? (lines with 0 stroke aren't visible) I guess they are the same so in this first patch I do the same both in fillShape() and strokeShape(). (Hmm... or perhaps I should omit this function because I defined an early return for lines with zero stroke-width at creating so it shouldn't be called neither.)

WebKit Review Bot

Comment 2 2012-03-20 03:16:12 PDT

Comment on attachment 132549 [details] Draft patch Attachment 132549 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12009093 New failing tests: svg/W3C-SVG-1.1/animate-elem-17-t.svg svg/W3C-SVG-1.1/animate-elem-14-t.svg fast/backgrounds/animated-svg-as-mask.html svg/W3C-SVG-1.1/animate-elem-25-t.svg svg/W3C-SVG-1.1/animate-elem-32-t.svg svg/W3C-SVG-1.1/animate-elem-37-t.svg svg/W3C-SVG-1.1/animate-elem-19-t.svg http/tests/inspector/inspect-element.html svg/W3C-SVG-1.1/animate-elem-12-t.svg svg/as-background-image/animated-svg-as-background.html accessibility/aria-disabled.html svg/W3C-SVG-1.1/animate-elem-09-t.svg fast/loader/text-document-wrapping.html svg/W3C-SVG-1.1/animate-elem-02-t.svg svg/W3C-SVG-1.1/animate-elem-16-t.svg svg/W3C-SVG-1.1/animate-elem-15-t.svg svg/W3C-SVG-1.1/animate-elem-30-t.svg svg/W3C-SVG-1.1/animate-elem-27-t.svg svg/W3C-SVG-1.1/animate-elem-18-t.svg svg/as-image/animated-svg-as-image-same-image.html svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size.html http/tests/xmlhttprequest/xmlhttprequest-unsafe-redirect.html http/tests/inspector/compiler-source-mapping.html svg/W3C-SVG-1.1/animate-elem-11-t.svg svg/W3C-SVG-1.1-SE/pservers-grad-17-b.svg svg/W3C-SVG-1.1/animate-elem-13-t.svg svg/W3C-SVG-1.1/animate-elem-10-t.svg

Renata Hodovan

Comment 3 2012-05-31 02:51:38 PDT

Although this is just a draft patch, any comments would really be useful :)

Dirk Schulze

Comment 4 2014-05-13 22:42:04 PDT

See master bug. No more diversity at this point.

Note You need to log in before you can comment on or make changes to this bug.