Summary: | [Gtk] Webkit fails to build with --disable-geolocation | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | tuxator | ||||
Component: | Platform | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, benjamin, joone.hur, mrobinson, zan | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | 80030 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
tuxator
2012-03-17 10:09:10 PDT
Do these files just need ENABLE(GEOLOCATION) guards? I'm not sure what role they play in GTK. (In reply to comment #1) > Do these files just need ENABLE(GEOLOCATION) guards? I'm not sure what role they play in GTK. Guarding the entire file wouldn't be too desirable since that would change the API based on the compilation options. Hopefully I can take a moment to fix this tomorrow or the next day. Created attachment 133541 [details]
Patch
Comment on attachment 133541 [details]
Patch
Adding the cq flag.
Comment on attachment 133541 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=133541&action=review > Source/WebKit/gtk/webkit/webkitgeolocationpolicydecision.cpp:-26 > - > -using namespace WebCore; This is a bit backward? Why removing the namespace use? > Source/WebKit/gtk/webkit/webkitgeolocationpolicydecision.cpp:85 > + WEBKIT_WARN_FEATURE_NOT_PRESENT("Geolocation") Where does that macro come from? A quick grep on the source returns nothing. (In reply to comment #5) > (From update of attachment 133541 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=133541&action=review > > > Source/WebKit/gtk/webkit/webkitgeolocationpolicydecision.cpp:-26 > > - > > -using namespace WebCore; > > This is a bit backward? Why removing the namespace use? > Keeping this would require it to be wrapped in an ifdef. Otherwise if geolocation support is disabled, including the Geolocation.h header basically does nothing, meaning the 'using namespace WebCore;' statement causes compilation error. Because of that I switched to using WebCore::Geolocation rather than polluting the code with another ifdef. > > Source/WebKit/gtk/webkit/webkitgeolocationpolicydecision.cpp:85 > > + WEBKIT_WARN_FEATURE_NOT_PRESENT("Geolocation") > > Where does that macro come from? > A quick grep on the source returns nothing. This is added in the patch in bug #80030. Comment on attachment 133541 [details]
Patch
Ok, looks good then. Land this after 80030.
Committed r111915: <http://trac.webkit.org/changeset/111915> |