Bug 81424
| Summary: | WebUIDelegate call should pass URL | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Lynn Neir <lynn.neir> |
| Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> |
| Status: | UNCONFIRMED | ||
| Severity: | Normal | ||
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | PC | ||
| OS: | Windows 7 | ||
Lynn Neir
Currently, call to createWebViewWithRequest passes null for request arg in WebFrameLoaderClient::dispatchCreatePage (WebKit/win/WebCoreSupport/WebFrameLoadClient.cpp).
Would like it to pass through URL (if available).
Current code:
...
COMPtr<IWebView> newWebView;
if (FAILED(ui->createWebViewWithRequest(webView, 0, &newWebView)))
return 0;
...
Proposed Change:
...
COMPtr<IWebMutableURLRequest> request(AdoptCOM, WebMutableURLRequest::createInstance());
if (!action.isEmpty())
{
BString urlBstr(action.url());
request->setURL(urlBstr);
}
COMPtr<IWebView> newWebView;
if (FAILED(ui->createWebViewWithRequest(webView, request.get(), &newWebView)))
return 0;
...
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |