Summary: | [Qt][WK2] Avoid usage of manual scaling in the Qt scenegraph integration | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Noam Rosenthal <noam> | ||||||||||
Component: | Platform | Assignee: | Noam Rosenthal <noam> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | hausmann, jturcotte, kenneth, menard, ostap73, webkit.review.bot, zoltan | ||||||||||
Priority: | P2 | Keywords: | Qt | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
Noam Rosenthal
2012-03-16 10:35:28 PDT
Created attachment 132316 [details]
Patch
Comment on attachment 132316 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=132316&action=review > Source/WebKit2/UIProcess/qt/QtWebPageSGNode.cpp:58 > + void setScale(float scale) { m_scale = scale; } m_scale as well as this setScale method seems unused, now that we have the transform node as a parent of this item. > Source/WebKit2/UIProcess/qt/QtWebPageSGNode.cpp:131 > + if (m_contentsNode) I think you can remove the if() here :) Created attachment 132494 [details]
Patch for landing
Comment on attachment 132494 [details] Patch for landing Rejecting attachment 132494 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: get.pri patching file Source/WebKit2/UIProcess/API/qt/qquickwebpage.cpp Hunk #1 FAILED at 23. Hunk #2 FAILED at 81. Hunk #3 FAILED at 191. 3 out of 3 hunks FAILED -- saving rejects to file Source/WebKit2/UIProcess/API/qt/qquickwebpage.cpp.rej patching file Source/WebKit2/UIProcess/qt/QtWebPageSGNode.cpp patching file Source/WebKit2/UIProcess/qt/QtWebPageSGNode.h Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/11976635 Created attachment 132497 [details]
Patch
Created attachment 132499 [details]
Patch
Comment on attachment 132499 [details] Patch Rejecting attachment 132499 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: get.pri patching file Source/WebKit2/UIProcess/API/qt/qquickwebpage.cpp Hunk #1 FAILED at 23. Hunk #2 FAILED at 81. Hunk #3 FAILED at 191. 3 out of 3 hunks FAILED -- saving rejects to file Source/WebKit2/UIProcess/API/qt/qquickwebpage.cpp.rej patching file Source/WebKit2/UIProcess/qt/QtWebPageSGNode.cpp patching file Source/WebKit2/UIProcess/qt/QtWebPageSGNode.h Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/11975718 Comment on attachment 132499 [details]
Patch
Patch should now apply.
Comment on attachment 132499 [details] Patch Clearing flags on attachment: 132499 Committed r111138: <http://trac.webkit.org/changeset/111138> All reviewed patches have been landed. Closing bug. |