Bug 81356

Summary: [BlackBerry] Fix layering violations in network/blackberry
Product: WebKit Reporter: Joe Mason <joenotcharles>
Component: WebKit BlackBerryAssignee: Joe Mason <joenotcharles>
Status: RESOLVED INVALID    
Severity: Normal CC: andersca, jasonliuwebkit, joenotcharles, kpiascik, staikos, tonikitoo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch rwlbuis: review-

Joe Mason
Reported 2012-03-16 09:00:44 PDT
NetworkManager.cpp contains this code: static_cast<FrameLoaderClientBlackBerry*>(frame.loader()->client())->cookiesEnabled() This (and any similar casts) should be using PageClientBlackBerry instead. See https://bugs.webkit.org/show_bug.cgi?id=80401 for an example.
Attachments
Patch (5.28 KB, patch)
2012-03-21 01:47 PDT, Jason Liu 		no flags
DetailsFormatted DiffDiff
Patch (6.02 KB, patch)
2012-03-21 03:31 PDT, Jason Liu 		rwlbuis: review-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jason Liu
Comment 1 2012-03-21 01:47:39 PDT
Created attachment 132993 [details] Patch
Jason Liu
Comment 2 2012-03-21 03:31:14 PDT
Created attachment 133003 [details] Patch
Joe Mason
Comment 3 2012-03-21 09:00:13 PDT
(In reply to comment #2) > Created an attachment (id=133003) [details] > Patch That won't work - CookieJar::cookiesEnabled is unimplemented. Probably it should be, but that's a separate bug. I have a patch here that fixes this and a bunch of other layering violations. I just haven't had time to finish it off. Don't waste any more time on this - I'll get to it by the end of the week.
Jason Liu
Comment 4 2012-03-21 20:06:56 PDT
(In reply to comment #3) > (In reply to comment #2) > > Created an attachment (id=133003) [details] [details] > > Patch > > That won't work - CookieJar::cookiesEnabled is unimplemented. Probably it should be, but that's a separate bug. > > I have a patch here that fixes this and a bunch of other layering violations. I just haven't had time to finish it off. Don't waste any more time on this - I'll get to it by the end of the week. I am sorry to hear about that. I thought this is another bug for my 80800. I won't do any more on this bug. And thanks a lot for your reviewing of my patches.
Rob Buis
Comment 5 2012-04-03 13:44:00 PDT
Comment on attachment 133003 [details] Patch Get this out of the review queue, based on Joe's remarks.
Note You need to log in before you can comment on or make changes to this bug.