Bug 81350

Summary: SVG setCurrentTime with pauseAnimations bug.
Product: WebKit Reporter: Philip Rogers <pdr>
Component: SVGAssignee: Philip Rogers <pdr>
Status: RESOLVED FIXED    
Severity: Normal CC: jgw, rakssvg, webkit.review.bot, zimmermann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Repro case
none
Fix setCurrentTime for paused animations none

Philip Rogers
Reported 2012-03-16 07:40:40 PDT
Unconfirmed defect report from user: when I call setCurrentTime(0), a call to unpauseAnimations() afterwards introduces a 1s pause. May be related to: https://bugs.webkit.org/show_bug.cgi?id=12073
Attachments
Repro case (1.42 KB, text/html)
2012-03-16 16:10 PDT, Philip Rogers 		no flags
Details
Fix setCurrentTime for paused animations (4.13 KB, patch)
2012-06-25 21:47 PDT, Philip Rogers 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Philip Rogers
Comment 1 2012-03-16 16:10:50 PDT
Created attachment 132410 [details] Repro case Attaching a small repro case: it looks like calling setCurrentTime while paused is broken.
Raks
Comment 2 2012-06-04 06:21:50 PDT
Actually its not 1s. If in the code setCurrentTime() and unPauseAnimation() are called together means they are in consecutive lines of code then the animation starts after a time which is the time difference between the call to pauseAnimation() and unPauseAnimation(). Pretty strange !!
Raks
Comment 3 2012-06-04 06:25:04 PDT
Hi Joel, Can you take a look at this ? Maybe it is part of BUG 12073
Philip Rogers
Comment 4 2012-06-04 06:28:27 PDT
(In reply to comment #3) > Hi Joel, Can you take a look at this ? Maybe it is part of BUG 12073 I don't think Joel is able to look at this so it is up for grabs :) Also, a good starter bug for new webkittens.
Philip Rogers
Comment 5 2012-06-25 21:47:16 PDT
Created attachment 149448 [details] Fix setCurrentTime for paused animations
Nikolas Zimmermann
Comment 6 2012-06-26 02:44:42 PDT
Comment on attachment 149448 [details] Fix setCurrentTime for paused animations pdr++, r=me.
WebKit Review Bot
Comment 7 2012-06-26 03:06:49 PDT
Comment on attachment 149448 [details] Fix setCurrentTime for paused animations Clearing flags on attachment: 149448 Committed r121246: <http://trac.webkit.org/changeset/121246>
WebKit Review Bot
Comment 8 2012-06-26 03:06:54 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.