Bug 81330 – REGRESSION(r110976): webkit_unit_tests crashes. (Requested by morrita on #webkit).

• Component: New Bugs
• Status: RESOLVED FIXED

[WebKit Review Bot]

http://trac.webkit.org/changeset/110976 broke the build:
webkit_unit_tests crashes. (Requested by morrita on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear

[WebKit Review Bot]

Created attachment 132245 [details]
ROLLOUT of r110976

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.

[Hajime Morrita]

http://chromegw.corp.google.com/i/chromium.webkit/builders/Webkit%20Mac10.6/builds/13642

Here is the stack trace:
[----------] 2 tests from WebPageSerializerTest
[ RUN      ] WebPageSerializerTest.HTMLNodes
[21953:21961:0316/030150:479780855:WARNING:proxy_service.cc(958)] PAC support disabled because there is no system implementation
[21953:21953:0316/030150:479783475:FATAL:resource_bundle.cc(97)] Check failed: g_shared_instance_ != NULL. 
[21953:21953:0316/030150:479783475:FATAL:resource_bundle.cc(97)] Check failed: g_shared_instance_ != NULL. 
	base::debug::StackTrace::StackTrace() [0x18aa32e]
	base::(anonymous namespace)::StackDumpSignalHandler() [0x1891259]
	0x7fe2a40f6af0
	0x7fe2a40f6a75
	0x7fe2a40fa5c0
	base::debug::BreakDebugger() [0x1871719]
	logging::LogMessage::~LogMessage() [0x187eee4]
	ui::ResourceBundle::GetSharedInstance() [0xd454e2]
	TestWebKitPlatformSupport::GetLocalizedString() [0x8879e8]
	webkit_glue::WebKitPlatformSupportImpl::queryLocalizedString() [0x17ccced]
	TestWebKitPlatformSupport::queryLocalizedString() [0x889658]
	WebCore::query() [0x1862150]
	WebCore::inputElementAltText() [0x18624fe]
	WebCore::HTMLInputElement::altText() [0xd91339]
	WebCore::RenderImage::updateAltText() [0x13da1aa]
	WebCore::RenderImage::RenderImage() [0x13da30c]
	WebCore::ImageInputType::createRenderer() [0xe447e2]
	WebCore::NodeRendererFactory::createRenderer() [0x8dc3d7]
	WebCore::NodeRendererFactory::createRendererIfNeeded() [0x8dcb0f]
	WebCore::Node::createRendererIfNeeded() [0x8d0628]
	WebCore::Element::attach() [0x8be058]
	WebCore::HTMLFormControlElement::attach() [0xd83f91]
	WebCore::HTMLInputElement::attach() [0xd9215a]
	WebCore::ContainerNode::attach() [0x88c734]
	WebCore::Element::attach() [0x8be161]
	WebCore::ContainerNode::attach() [0x88c734]
	WebCore::Element::attach() [0x8be161]
	WebCore::Element::recalcStyle() [0x8bf17a]
	WebCore::Element::recalcStyle() [0x8bedb5]
	WebCore::Document::recalcStyle() [0x8a74db]
	WebCore::Document::styleSelectorChanged() [0x8a7992]
	WebCore::Document::removePendingSheet() [0x8a7aea]
	WebCore::HTMLLinkElement::sheetLoaded() [0xd93430]
	WebCore::CSSStyleSheet::checkLoaded() [0x103241a]
	WebCore::HTMLLinkElement::setCSSStyleSheet() [0xd93d51]
	WebCore::CachedCSSStyleSheet::checkNotify() [0x118190c]
	WebCore::CachedResource::stopLoading() [0x1185968]
	WebCore::SubresourceLoader::releaseResources() [0x1174a0c]
	WebCore::ResourceLoader::cancel() [0x116efcb]
	WebCore::ResourceLoader::cancel() [0x1170070]
	WebCore::cancelAll() [0x1134e42]
	WebCore::DocumentLoader::stopLoading() [0x1135166]
	WebCore::FrameLoader::stopAllLoaders() [0x11479d2]
	WebCore::FrameLoader::frameDetached() [0x114848b]
	WebKit::WebViewImpl::close() [0x829518]
	testing::TestInfo::Run() [0x87a02a]
	testing::TestCase::Run() [0x87a177]
	testing::internal::UnitTestImpl::RunAllTests() [0x87a40d]
	testing::UnitTest::Run() [0x878c13]
	base::TestSuite::Run() [0x884f48]
	main [0x419fd0]
	0x7fe2a40e1c4d
	0x419e99

[WebKit Review Bot]

Comment on attachment 132245 [details]
ROLLOUT of r110976

Clearing flags on attachment: 132245

Committed r110986: <http://trac.webkit.org/changeset/110986>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Alexey Proskuryakov]

Please always reopen a bug when rolling out its fix.

Also, it seems uncertain if this was indeed the reason for this crash.

[Nate Chapin]

(In reply to comment #5)
> Please always reopen a bug when rolling out its fix.
> 
> Also, it seems uncertain if this was indeed the reason for this crash.

This patch definitely triggered the crash, but I think it's a bug in the chromium-mac test support. We're derefing a null pointer that is intentionally left uninitialized for webkit_unit_tests in . I don't know anything about this code, so I need to go hunting for someone that knows its history.

[Hajime Morrita]

(In reply to comment #5)
> Please always reopen a bug when rolling out its fix.
Oops. I should've done so. I'm sorry for being unaware of this.