Bug 81310

Summary: fast/dom/shadow/content-element-in-media.html is wrong.
Product: WebKit Reporter: Shinya Kawanaka <shinyak>
Component: DOMAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: morrita, shinyak, tasak, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 79221    
Attachments:
Description Flags
Repro
none
Patch
none
Patch
none
Patch none

Shinya Kawanaka
Reported 2012-03-15 23:04:42 PDT
The render object generated by <video> having <content> differs from <video> not having <content>
Attachments
Repro (1.20 KB, text/html)
2012-03-15 23:05 PDT, Shinya Kawanaka 		no flags
Details
Patch (3.44 KB, patch)
2012-05-14 01:16 PDT, Takashi Sakamoto 		no flags
DetailsFormatted DiffDiff
Patch (3.45 KB, patch)
2012-05-16 19:18 PDT, Takashi Sakamoto 		no flags
DetailsFormatted DiffDiff
Patch (3.48 KB, patch)
2012-05-25 03:05 PDT, Takashi Sakamoto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Shinya Kawanaka
Comment 1 2012-03-15 23:05:30 PDT
Created attachment 132204 [details] Repro place it in fast/dom/shadow
Takashi Sakamoto
Comment 2 2012-05-14 01:16:23 PDT
Created attachment 141663 [details] Patch
Darin Adler
Comment 3 2012-05-14 10:10:05 PDT
Comment on attachment 141663 [details] Patch It’s confusing that this fix for a test has a change log that makes it look like it’s fixing a bug in the handling of the <content> element. I don’t think it’s good practice to label a patch that does not fix a bug with the bug number for the bug.
Hajime Morrita
Comment 4 2012-05-15 22:23:47 PDT
Comment on attachment 141663 [details] Patch based on darin's comment.
Shinya Kawanaka
Comment 5 2012-05-16 18:39:12 PDT
Since tasak found that it is the test that is wrong, let's change the bug title.
Takashi Sakamoto
Comment 6 2012-05-16 19:18:05 PDT
Created attachment 142393 [details] Patch
Takashi Sakamoto
Comment 7 2012-05-16 19:29:31 PDT
(In reply to comment #5) > Since tasak found that it is the test that is wrong, let's change the bug title. Thank you for changing the bug title, Shinya. I modified LayoutTests/ChangeLog according to the change.
Hajime Morrita
Comment 8 2012-05-20 17:34:42 PDT
Comment on attachment 142393 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=142393&action=review > LayoutTests/platform/chromium/test_expectations.txt:2752 > +BUGWK81310 : fast/dom/shadow/content-element-in-media-element.html = PASS TEXT You can just remove this once the test passes. "PASS TEXT" is implying some flakiness.
Hajime Morrita
Comment 9 2012-05-20 17:35:31 PDT
Comment on attachment 142393 [details] Patch ...but that's fine for land this once it gets fixed ;-)
Takashi Sakamoto
Comment 10 2012-05-25 03:05:21 PDT
Created attachment 144024 [details] Patch
WebKit Review Bot
Comment 11 2012-05-27 17:29:05 PDT
Comment on attachment 144024 [details] Patch Clearing flags on attachment: 144024 Committed r118633: <http://trac.webkit.org/changeset/118633>
WebKit Review Bot
Comment 12 2012-05-27 17:29:10 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.