Bug 81269

Summary: [BlackBerry] Use BlackBerry::Platform::DeviceInfo to generate UserAgent
Product: WebKit Reporter: Mike Lattanzio <mlattanzio>
Component: WebKit BlackBerryAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Other   
Attachments:
Description Flags
Patch
none
Updated patch, resolved conflicts in WebPage_p.h none

Mike Lattanzio
Reported 2012-03-15 14:51:22 PDT
We should be using DeviceInfo to dynamically generate our UserAgent string.
Attachments
Patch (6.26 KB, patch)
2012-03-15 14:57 PDT, Mike Lattanzio 		no flags
DetailsFormatted DiffDiff
Updated patch, resolved conflicts in WebPage_p.h (7.42 KB, patch)
2012-03-19 10:26 PDT, Mike Lattanzio 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mike Lattanzio
Comment 1 2012-03-15 14:57:54 PDT
Created attachment 132127 [details] Patch
Mike Lattanzio
Comment 2 2012-03-19 10:26:53 PDT
Created attachment 132603 [details] Updated patch, resolved conflicts in WebPage_p.h
Rob Buis
Comment 3 2012-03-19 10:57:45 PDT
Comment on attachment 132603 [details] Updated patch, resolved conflicts in WebPage_p.h View in context: https://bugs.webkit.org/attachment.cgi?id=132603&action=review LGTM. > Source/WebKit/blackberry/Api/WebPage.cpp:5683 > + BlackBerry::Platform::DeviceInfo* info = BlackBerry::Platform::DeviceInfo::instance(); You can probably leave off BlackBerry:: prefix.
WebKit Review Bot
Comment 4 2012-03-19 11:36:42 PDT
Comment on attachment 132603 [details] Updated patch, resolved conflicts in WebPage_p.h Clearing flags on attachment: 132603 Committed r111209: <http://trac.webkit.org/changeset/111209>
WebKit Review Bot
Comment 5 2012-03-19 11:36:46 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.