Bug 81267
| Summary: | The chromium turducken is making project-wide searching impossible | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED WONTFIX | ||
| Severity: | Normal | CC: | abarth, dglazkov, tony |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Eric Seidel (no email)
The chromium turducken is making project-wide searching impossible
We pull in some 40,000 source files into WebKit/chromium as part of update-webkit-chromium. It would be nice if they were pulled into some location outside of Source/WebKit (like the build directory, or ThirdParty?) so that project-wide grepping is much easier. :)
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Eric Seidel (no email)
Similarly, we'd love to:
git clean -f -d
on the EWS bots when they reboot themselves (every couple hours or so).
Currently we can't pass -d, or we blast away the turducken (which slams Chromium servers with another full download.. and makes our poor EWSes wait 15 minutes to refetch everything).
Tony Chang
(In reply to comment #0)
> The chromium turducken is making project-wide searching impossible
>
> We pull in some 40,000 source files into WebKit/chromium as part of update-webkit-chromium. It would be nice if they were pulled into some location outside of Source/WebKit (like the build directory, or ThirdParty?) so that project-wide grepping is much easier. :)
Would git grep work for you? How does WebKitBuild avoid being searched?
Eric Seidel (no email)
(In reply to comment #2)
> (In reply to comment #0)
> > The chromium turducken is making project-wide searching impossible
> >
> > We pull in some 40,000 source files into WebKit/chromium as part of update-webkit-chromium. It would be nice if they were pulled into some location outside of Source/WebKit (like the build directory, or ThirdParty?) so that project-wide grepping is much easier. :)
>
> Would git grep work for you? How does WebKitBuild avoid being searched?
I was searching in Sublime, under the Source/WebKit directory, updating wtf includes, when I ran into this. I ended up having to search only in src/ and tests/ instead.
When I use grep, I generally just grep Source. I don't normally have the turducken in my checkout, as I'm normally building AppleMac, but today I was fixing wtf includes for Chromium for the upcoming WTF move.
Tony Chang
You should use git grep, it's also faster :)
Also, I'm pretty sure git clean -f -d will work just fine. All the directories pulled in by gclient are in .gitignore, so they won't get blown away (i.e., git status doesn't show any of those directories on my checkout).
Stephen Chenney
Marked LayoutTest bugs, bugs with Chromium IDs, and some others as WontFix. Test failure bugs still are trackable via TestExpectations or disabled unit tests.