Bug 81224

Summary: Web Inspector: improve HeapSnapshot._buildReversIndex performance
Product: WebKit Reporter: Yury Semikhatsky <yurys>
Component: Web Inspector (Deprecated)Assignee: Yury Semikhatsky <yurys>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch pfeldman: review+

Yury Semikhatsky
Reported 2012-03-15 09:05:46 PDT
Caching node indexes and node count in local variables instead of calling getters each time reduces the method run time by factor of 1.5
Attachments
Patch (2.73 KB, patch)
2012-03-15 09:07 PDT, Yury Semikhatsky 		pfeldman: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yury Semikhatsky
Comment 1 2012-03-15 09:07:26 PDT
Created attachment 132059 [details] Patch
Yury Semikhatsky
Comment 2 2012-03-15 09:10:54 PDT
For the WebKit/PerformanceTests/inspector/detailed-heapshots-smoke-test.html test with the patch applied: RESULT heap-snapshot: _buildDominatedNodes= 2857 ms without: RESULT heap-snapshot: _buildDominatedNodes= 4417 ms
Yury Semikhatsky
Comment 3 2012-03-15 09:40:24 PDT
Committed r110853: <http://trac.webkit.org/changeset/110853>
Note You need to log in before you can comment on or make changes to this bug.