Bug 81178

Summary: Prepare RenderObject for FractionalLayoutUnits
Product: WebKit Reporter: Levi Weintraub <leviw>
Component: Layout and RenderingAssignee: Levi Weintraub <leviw>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, eae, eric, jchaffraix, simon.fraser, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 60318    
Attachments:
Description Flags
Patch none

Levi Weintraub
Reported 2012-03-14 18:08:10 PDT
This patch brings prepares RenderObject for FractionalLayoutUnits as a backend for LayoutUnits. This fixes a few compiler errors, adds a flavor of adjustForAbsoluteZoom that directly takes a FractionalLayoutUnit, and reverts outlines to ints.
Attachments
Patch (6.79 KB, patch)
2012-03-14 18:32 PDT, Levi Weintraub 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Levi Weintraub
Comment 1 2012-03-14 18:32:14 PDT
Created attachment 131970 [details] Patch
Levi Weintraub
Comment 2 2012-03-16 14:51:35 PDT
Pingin' those happy reviewers once again.
Eric Seidel (no email)
Comment 3 2012-03-16 14:53:57 PDT
Comment on attachment 131970 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=131970&action=review > Source/WebCore/rendering/RenderObject.cpp:1368 > +IntRect RenderObject::pixelSnappedAbsoluteClippedOverflowRect() const > +{ > + return pixelSnappedIntRect(absoluteClippedOverflowRect()); > +} Bleh. Why wouldn't people just call absoluteClippedOverFlowRect().snapped()?
Levi Weintraub
Comment 4 2012-03-16 15:03:37 PDT
Comment on attachment 131970 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=131970&action=review >> Source/WebCore/rendering/RenderObject.cpp:1368 >> +} > > Bleh. Why wouldn't people just call absoluteClippedOverFlowRect().snapped()? Primarily we have this function to export from WebCore. We don't want to expose the LayoutRect version to outside callers.
WebKit Review Bot
Comment 5 2012-03-16 16:05:50 PDT
Comment on attachment 131970 [details] Patch Clearing flags on attachment: 131970 Committed r111082: <http://trac.webkit.org/changeset/111082>
WebKit Review Bot
Comment 6 2012-03-16 16:05:54 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.