Bug 81178

Summary: Prepare RenderObject for FractionalLayoutUnits
Product: WebKit Reporter: Levi Weintraub <leviw>
Component: Layout and RenderingAssignee: Levi Weintraub <leviw>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, eae, eric, jchaffraix, simon.fraser, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 60318    
Attachments:
Description Flags
Patch none

Description Levi Weintraub 2012-03-14 18:08:10 PDT 
This patch brings prepares RenderObject for FractionalLayoutUnits as a backend for LayoutUnits. This fixes a few compiler errors, adds a flavor of adjustForAbsoluteZoom that directly takes a FractionalLayoutUnit, and reverts outlines to ints.
Comment 1 Levi Weintraub 2012-03-14 18:32:14 PDT 
Created attachment 131970 [details]
Patch
Comment 2 Levi Weintraub 2012-03-16 14:51:35 PDT 
Pingin' those happy reviewers once again.
Comment 3 Eric Seidel (no email) 2012-03-16 14:53:57 PDT 
Comment on attachment 131970 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=131970&action=review

> Source/WebCore/rendering/RenderObject.cpp:1368
> +IntRect RenderObject::pixelSnappedAbsoluteClippedOverflowRect() const
> +{
> +    return pixelSnappedIntRect(absoluteClippedOverflowRect());
> +}

Bleh.  Why wouldn't people just call absoluteClippedOverFlowRect().snapped()?
Comment 4 Levi Weintraub 2012-03-16 15:03:37 PDT 
Comment on attachment 131970 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=131970&action=review

>> Source/WebCore/rendering/RenderObject.cpp:1368
>> +}
> 
> Bleh.  Why wouldn't people just call absoluteClippedOverFlowRect().snapped()?

Primarily we have this function to export from WebCore. We don't want to expose the LayoutRect version to outside callers.
Comment 5 WebKit Review Bot 2012-03-16 16:05:50 PDT 
Comment on attachment 131970 [details]
Patch

Clearing flags on attachment: 131970

Committed r111082: <http://trac.webkit.org/changeset/111082>
Comment 6 WebKit Review Bot 2012-03-16 16:05:54 PDT 
All reviewed patches have been landed.  Closing bug.