Summary: | REGRESSION (NativeTextField): Drag and drop text within a text input field modifies page | ||
---|---|---|---|
Product: | WebKit | Reporter: | PCheese <mulletsailors> |
Component: | HTML Editing | Assignee: | Justin Garcia <justin.garcia> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | Keywords: | Regression |
Priority: | P1 | ||
Version: | 420+ | ||
Hardware: | Mac | ||
OS: | OS X 10.4 | ||
URL: | http://google.com/ |
Description
PCheese
2006-03-31 23:14:32 PST
Same problem with normal contenteditable divs. ================= ASSERTION FAILED: editableRoot (/Users/ap/WebKit/WebCore/editing/ReplaceSelectionCommand.cpp:124 WebCore::ReplacementFragment::ReplacementFragment(WebCore::Document*, WebCore::DocumentFragment*, bool)) ================= Ah, when a ReplaceSelectionCommand is a sub-command (which is what happens during a drag), frame->selection() may be different than the endingSelection. The ReplacementFragment will need to either be given the endingSelection or a pointer back to the ReplaceSelectionCommand so it can get the endingSelection. We should get rid of the endingSelection, it's confusing. An operation should just set its selection on the frame, but through a special setter that doesn't send selection change notifications (those should only be sent for user-level selection changes). These are all text field regressions so they should all be P1. |