Bug 81155

Summary: Add a new perf test to benchmark setting and reading CSS properties from JS.
Product: WebKit Reporter: Alexis Menard (darktears) <menard>
Component: New BugsAssignee: Alexis Menard (darktears) <menard>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, dglazkov, kling, rniwa, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Alexis Menard (darktears) 2012-03-14 13:56:05 PDT 
Add a new perf test to benchmark setting and reading CSS properties from JS.
Comment 1 Alexis Menard (darktears) 2012-03-14 13:57:23 PDT 
Created attachment 131917 [details]
Patch
Comment 2 WebKit Review Bot 2012-03-14 16:43:04 PDT 
Comment on attachment 131917 [details]
Patch

Attachment 131917 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/11952485

New failing tests:
svg/repaint/repainting-after-animation-element-removal.svg
Comment 3 Alexis Menard (darktears) 2012-03-14 17:08:09 PDT 
(In reply to comment #2)
> (From update of attachment 131917 [details])
> Attachment 131917 [details] did not pass chromium-ews (chromium-xvfb):
> Output: http://queues.webkit.org/results/11952485
> 
> New failing tests:
> svg/repaint/repainting-after-animation-element-removal.svg

oO really? Why so much hate EWS?
Comment 4 Ryosuke Niwa 2012-03-14 17:42:30 PDT 
Comment on attachment 131917 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=131917&action=review

> PerformanceTests/ChangeLog:11
> +        * DOM/CSSPropertySetterGetter.html: Added.

Maybe we should add PerformanceTests/CSSOM or PerformanceTests/CSS?

> PerformanceTests/DOM/CSSPropertySetterGetter.html:1
> +<html>

DOCTYPE?

> PerformanceTests/DOM/CSSPropertySetterGetter.html:75
> +        // We benchmark the property getter.

This is self-evident.

> PerformanceTests/DOM/CSSPropertySetterGetter.html:80
> +        // We benchmark the property setter.

Ditto.
Comment 5 Alexis Menard (darktears) 2012-03-14 17:51:10 PDT 
Created attachment 131965 [details]
Patch
Comment 6 Alexis Menard (darktears) 2012-03-15 01:57:24 PDT 
Comment on attachment 131965 [details]
Patch

Clearing flags on attachment: 131965

Committed r110833: <http://trac.webkit.org/changeset/110833>
Comment 7 Alexis Menard (darktears) 2012-03-15 01:57:33 PDT 
All reviewed patches have been landed.  Closing bug.