Bug 81144 – [Qt][WK2] Fix bounce-back behaviour for panning

• Component: New Bugs
• Status: RESOLVED FIXED

[Andras Becsi]

The pan gesture should be cancelled and the content should be moved to the end position immediately when tapping during the bounce-back animation.

[Andras Becsi]

Created attachment 131904 [details]
proposed patch

[Kenneth Rohde Christiansen]

Comment on attachment 131904 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=131904&action=review

> Source/WebKit2/UIProcess/qt/QtPanGestureRecognizer.cpp:70
>          interactionEngine()->panGestureCancelled();
> +        interactionEngine()->ensureContentWithinViewportBoundary(/*immediate*/ true);
>          return false;

hmm, yes you move it back immediately, but isn't the other animation still running?

[Andras Becsi]

(In reply to comment #2)
> (From update of attachment 131904 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=131904&action=review
> 
> > Source/WebKit2/UIProcess/qt/QtPanGestureRecognizer.cpp:70
> >          interactionEngine()->panGestureCancelled();
> > +        interactionEngine()->ensureContentWithinViewportBoundary(/*immediate*/ true);
> >          return false;
> 
> hmm, yes you move it back immediately, but isn't the other animation still running?

No, it is stopped by the interactionEngine()->panGestureCancelled() call.
This results in a cancelFlick() call to the Flickable, which just stops the animation where it was without returning into valid boundaries.
Since Flickable has no public API for immediate position correction, we need to use our own implementation here.

[Andras Becsi]

Comment on attachment 131904 [details]
proposed patch

Clearing flags on attachment: 131904

Committed r110850: <http://trac.webkit.org/changeset/110850>

[Andras Becsi]

All reviewed patches have been landed.  Closing bug.

[Andras Becsi]

This causes an assert in the interaction engine, reopening and preparing a new patch.

[Andras Becsi]

Created attachment 132283 [details]
proposed patch

[Kenneth Rohde Christiansen]

Comment on attachment 132283 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=132283&action=review

> Source/WebKit2/ChangeLog:10
> +        ongoing kinetic scroll or bounce-back animation from a previous pan
> +        gesture the animation is stopped and the content is positioned back

weird english

> Source/WebKit2/ChangeLog:11
> +        to valid boundaries immediately.

I would use immediately earlier

> Source/WebKit2/UIProcess/qt/QtViewportInteractionEngine.cpp:498
> +    // ongoing kinetic scroll or bounce-back animation from a previous pan
> +    // gesture the animation is stopped and the content is positioned back

We only want that for kinetic scroll. Bounce back should be handled differently. ie. if there is a bounce back or other kind of scale animation (tap to zoom) then it should be completed before other events can be accepted

[Philippe Normand]

Comment on attachment 132283 [details]
proposed patch

Attachment 132283 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/11962348

[Andras Becsi]

(In reply to comment #9)
> (From update of attachment 132283 [details])
> Attachment 132283 [details] did not pass gtk-ews (gtk):
> Output: http://queues.webkit.org/results/11962348

This looks bogus to me, the ews seem busted.

[Philippe Normand]

(In reply to comment #10)
> (In reply to comment #9)
> > (From update of attachment 132283 [details] [details])
> > Attachment 132283 [details] [details] did not pass gtk-ews (gtk):
> > Output: http://queues.webkit.org/results/11962348
> 
> This looks bogus to me, the ews seem busted.

It was indeed. I've fixed this since then! Sorry for the noise

[Andras Becsi]

Committed r111015: <http://trac.webkit.org/changeset/111015>

[Andras Becsi]

Comment on attachment 132283 [details]
proposed patch

Clearing flags from attachment.

[Dinu Jacob]

*** Bug 81382 has been marked as a duplicate of this bug. ***