Bug 8113

Summary: Disable crash report dialogs for testkjs.exe in Release mode
Product: WebKit Reporter: Björn Graf (boki) <bjoern.graf>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-webkit
Priority: P2    
Version: 420+   
Hardware: PC   
OS: Windows XP   
Bug Depends on:    
Bug Blocks: 3356    
Attachments:
Description Flags
Adds SEH to main in Release builds
none
Always use separate main functions darin: review+

Björn Graf (boki)
Reported 2006-03-31 16:20:09 PST
To simplify running JavaScriptCore/tests/mozilla/jsDriver.pl on Windows use SEH to catch access violation exceptions. That way the crash dialog is not shown and the tests run through without the need to dismiss any dialogs.
Attachments
Adds SEH to main in Release builds (965 bytes, patch)
2006-03-31 16:20 PST, Björn Graf (boki) 		no flags
DetailsFormatted DiffDiff
Always use separate main functions (2.20 KB, patch)
2006-04-01 05:52 PST, Björn Graf (boki) 		darin: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Björn Graf (boki)
Comment 1 2006-03-31 16:20:58 PST
Created attachment 7428 [details] Adds SEH to main in Release builds
Darin Adler
Comment 2 2006-03-31 23:15:03 PST
Comment on attachment 7428 [details] Adds SEH to main in Release builds Seems like a fine fix, but we don't have to do it in a strange way like this. We can always have the separate main function.
Björn Graf (boki)
Comment 3 2006-04-01 05:52:29 PST
Created attachment 7440 [details] Always use separate main functions This time with some preprocessor voodoo :]
Darin Adler
Comment 4 2006-04-01 08:35:34 PST
Comment on attachment 7440 [details] Always use separate main functions Looks fine. r=me
David Kilzer (:ddkilzer)
Comment 5 2006-04-01 15:15:57 PST
(In reply to comment #4) > (From update of attachment 7440 [details] [edit]) > Looks fine. r=me NOTE: This patch has bits from attachment 7427 [details] from Bug 7399 in it!
Eric Seidel (no email)
Comment 6 2006-04-04 05:06:38 PDT
Note: This patch is missing a changelog, as well as copyright information. I will add those as I land this time, but please be sure to include such in your future patches.
Note You need to log in before you can comment on or make changes to this bug.