Bug 81121 – [BlackBerry] Add WebPageCompositor class to BlackBerry WebKit API

• Component: WebKit BlackBerry
• Status: RESOLVED FIXED

[Arvid Nilsson]

This is used to render the web page when we don't have a screen window.

[Arvid Nilsson]

Created attachment 132425 [details]
Patch

[Rob Buis]

Comment on attachment 132425 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=132425&action=review

Looks good.

> Source/WebKit/blackberry/Api/WebPageCompositorClient.h:27
> +class WebPage;

Does not seem needed.

[WebKit Review Bot]

Comment on attachment 132425 [details]
Patch

Rejecting attachment 132425 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
/WebPageCompositor.h
patching file Source/WebKit/blackberry/Api/WebPageCompositorClient.h
patching file Source/WebKit/blackberry/Api/WebPageCompositor_p.h
Hunk #3 FAILED at 74.
1 out of 3 hunks FAILED -- saving rejects to file Source/WebKit/blackberry/Api/WebPageCompositor_p.h.rej
patching file Source/WebKit/blackberry/Api/WebPage_p.h

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Rob Buis']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/11963622

[Arvid Nilsson]

Created attachment 133587 [details]
Patch

[Arvid Nilsson]

Alright, trying again =)

[Rob Buis]

Comment on attachment 133587 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=133587&action=review

Looks good.

> Source/WebKit/blackberry/Api/WebPageCompositor.cpp:239
> +WebPageCompositor::WebPageCompositor(WebPage* page, WebPageCompositorClient* client)

You could omit the param names, as you are not using them.

> Source/WebKit/blackberry/Api/WebPageCompositorClient.h:27
> +class WebPage;

You are not using WebPage in this file.

[Arvid Nilsson]

(In reply to comment #6)
> (From update of attachment 133587 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=133587&action=review
> 
> Looks good.
> 
> > Source/WebKit/blackberry/Api/WebPageCompositor.cpp:239
> > +WebPageCompositor::WebPageCompositor(WebPage* page, WebPageCompositorClient* client)
> 
> You could omit the param names, as you are not using them.
> 
> > Source/WebKit/blackberry/Api/WebPageCompositorClient.h:27
> > +class WebPage;
> 
> You are not using WebPage in this file.

D'oh, you already told me that the last time around =) Hang on, I can fix and put a new patch up.

[Rob Buis]

Comment on attachment 133587 [details]
Patch

Stop so Arvid can fix the forward reference.

[Arvid Nilsson]

Created attachment 133595 [details]
Patch

[Rob Buis]

Comment on attachment 133595 [details]
Patch

Looks good, another try :)

[WebKit Review Bot]

Comment on attachment 133595 [details]
Patch

Clearing flags on attachment: 133595

Committed r111959: <http://trac.webkit.org/changeset/111959>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.