Bug 81120

Summary: [BlackBerry] Syncing up left over bits in WebCoreSupport from our local branch to upstream
Product: WebKit Reporter: Nima Ghanavatian <nima.ghanavatian>
Component: WebKit BlackBerryAssignee: Nima Ghanavatian <nima.ghanavatian>
Status: RESOLVED FIXED    
Severity: Normal CC: rwlbuis, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Nima Ghanavatian
Reported 2012-03-14 09:02:25 PDT
This is a consolidation of various changes that are in our local dev branch but do not appear in our upstreamed port.
Attachments
Patch (30.74 KB, patch)
2012-03-14 09:06 PDT, Nima Ghanavatian 		no flags
DetailsFormatted DiffDiff
Patch (30.74 KB, patch)
2012-03-14 10:48 PDT, Nima Ghanavatian 		no flags
DetailsFormatted DiffDiff
Patch (21.44 KB, patch)
2012-03-16 11:03 PDT, Nima Ghanavatian 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Nima Ghanavatian
Comment 1 2012-03-14 09:06:32 PDT
Created attachment 131868 [details] Patch
Nima Ghanavatian
Comment 2 2012-03-14 10:48:41 PDT
Created attachment 131880 [details] Patch
Rob Buis
Comment 3 2012-03-14 11:15:28 PDT
Comment on attachment 131880 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=131880&action=review Some code needs to be stripped out. > Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp:551 > + } This is the "BrowserField2" code, we do not want it in.
Nima Ghanavatian
Comment 4 2012-03-16 11:03:00 PDT
Created attachment 132320 [details] Patch
Rob Buis
Comment 5 2012-03-16 12:15:02 PDT
Comment on attachment 132320 [details] Patch Looks good.
WebKit Review Bot
Comment 6 2012-03-16 13:00:38 PDT
Comment on attachment 132320 [details] Patch Clearing flags on attachment: 132320 Committed r111050: <http://trac.webkit.org/changeset/111050>
WebKit Review Bot
Comment 7 2012-03-16 13:00:43 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.